Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-11-16 12:34:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Sanity check coff-sh and coff-mcore sym string offset

Browse Source 
* coff-mcore.c (coff_mcore_relocate_section): Sanity check sym
	string offset when setting up name for use by error messages.
	* coff-sh.c (sh_relocate_section): Likewise.
This commit is contained in:
Alan Modra
2023-03-22 09:06:48 +10:30
parent 317e47ee5e
commit 4d5b27b30b
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
bfd/coff-mcore.c
View File

@@ -434,7 +434,13 @@ coff_mcore_relocate_section (bfd * output_bfd,
my_name = "*unknown*";
else if ( sym->_n._n_n._n_zeroes == 0
&& sym->_n._n_n._n_offset != 0)
my_name = obj_coff_strings (input_bfd) + sym->_n._n_n._n_offset;
{
if (sym->_n._n_n._n_offset < obj_coff_strings_len (input_bfd))
my_name = (obj_coff_strings (input_bfd)
+ sym->_n._n_n._n_offset);
else
my_name = "?";
}
else
{
strncpy (buf, sym->_n._n_name, SYMNMLEN);

7
bfd/coff-sh.c
View File

@@ -2866,7 +2866,12 @@ sh_relocate_section (bfd *output_bfd ATTRIBUTE_UNUSED,
name = NULL;
else if (sym->_n._n_n._n_zeroes == 0
&& sym->_n._n_n._n_offset != 0)
name = obj_coff_strings (input_bfd) + sym->_n._n_n._n_offset;
{
if (sym->_n._n_n._n_offset < obj_coff_strings_len (input_bfd))
name = obj_coff_strings (input_bfd) + sym->_n._n_n._n_offset;
else
name = "?";
}
else
{
strncpy (buf, sym->_n._n_name, SYMNMLEN);