Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-26 09:08:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

PR17910 sym string offset check

Browse Source 
As far as I can see the only place that sets obj_coff_strings without
setting obj_coff_strings_len is pe_ILF_build_a_bfd.  Fix that and we
can simplify the sym string offset check.  This is just a tidy.
pe_ILF_build_a_bfd doesn't create bad symbols and
_bfd_coff_read_string_table will always result in non-zero
obj_coff_strings_len when obj_coff_strings is non-NULL.

	PR 17910
	* coffgen.c (_bfd_coff_internal_syment_name): Always sanity
	check sym string offset.
	* peicode.h (pe_ILF_build_a_bfd): Set obj_coff_strings_len.
This commit is contained in:
Alan Modra
2023-03-22 09:05:10 +10:30
parent 6634b21566
commit 317e47ee5e
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
bfd/coffgen.c
View File

@@ -443,10 +443,7 @@ _bfd_coff_internal_syment_name (bfd *abfd,
if (strings == NULL)
return NULL;
}
/* PR 17910: Only check for string overflow if the length has been set.
Some DLLs, eg those produced by Visual Studio, may not set the length field. */
if (obj_coff_strings_len (abfd) > 0
&& sym->_n._n_n._n_offset >= obj_coff_strings_len (abfd))
if (sym->_n._n_n._n_offset >= obj_coff_strings_len (abfd))
return NULL;
return strings + sym->_n._n_n._n_offset;
}

1
bfd/peicode.h
View File

@@ -1147,6 +1147,7 @@ pe_ILF_build_a_bfd (bfd * abfd,
obj_conv_table_size (abfd) = vars.sym_index;
obj_coff_strings (abfd) = vars.string_table;
obj_coff_strings_len (abfd) = vars.string_ptr - vars.string_table;
obj_coff_keep_strings (abfd) = true;
return true;