Files
binutils-gdb/gdb/testsuite/gdb.threads/schedlock-new-thread.c
Pedro Alves 7ac958f267 Don't resume new threads if scheduler-locking is in effect
If scheduler-locking is in effect, e.g., with "set scheduler-locking
on", and you step over a function that spawns a new thread, the new
thread is allowed to run free, at least until some event is hit, at
which point, whether the new thread is re-resumed depends on a number
of seemingly random factors.  E.g., if the target is all-stop, and the
parent thread hits a breakpoint, and GDB decides the breakpoint isn't
interesting to report to the user, then the parent thread is resumed,
but the new thread is left stopped.

I think that letting the new threads run with scheduler-locking
enabled is a defect.  This commit fixes that, making use of the new
clone events on Linux, and of target_thread_events() on targets where
new threads have no connection to the thread that spawned them.

Testcase and documentation changes included.

Approved-By: Eli Zaretskii <eliz@gnu.org>
Reviewed-By: Andrew Burgess <aburgess@redhat.com>
Change-Id: Ie12140138b37534b7fc1d904da34f0f174aa11ce
2023-11-13 14:16:11 +00:00

55 lines
1.5 KiB
C

/* This testcase is part of GDB, the GNU debugger.
Copyright 2021-2023 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include <pthread.h>
#include <assert.h>
#include <unistd.h>
static void *
thread_func (void *arg)
{
#if !SCHEDLOCK
while (1)
sleep (1);
#endif
return NULL;
}
int
main (void)
{
pthread_t thread;
int ret;
ret = pthread_create (&thread, NULL, thread_func, NULL); /* set break 1 here */
assert (ret == 0);
#if SCHEDLOCK
/* When testing with schedlock enabled, the new thread won't run, so
we can't join it, as that would hang forever. Instead, sleep for
a bit, enough that if the spawned thread is scheduled, it hits
the thread_func breakpoint before the main thread reaches the
"return 0" line below. */
sleep (3);
#else
pthread_join (thread, NULL);
#endif
return 0; /* set break 2 here */
}