forked from Imagelibrary/binutils-gdb
6b9efd5c1a
PR dap/32090 points out that gdb's DAP "launch" sequencing is
incorrect. The current approach (which is itself a 2nd
implementation...) was based on a misreading of the spec. The spec
has since been clarified here:
https://github.com/microsoft/debug-adapter-protocol/issues/497
The clarification here is that a client is free to send the "launch"
(or "attach") request at any point after the "initialized" event has
been sent by gdb. However, the "launch" does not cause any action to
be taken -- and does not send a response -- until after
"configurationDone" has been seen.
This patch implements this by arranging for the launch and attach
commands to return a DeferredRequest object.
All the tests needed updates. I've also added a new test that checks
that the deferred "launch" request can be cancelled. (Note that the
cancellation is lazy -- it also waits until configurationDone is seen.
This could be fixed, but I was not sure whether it is important to do
so.)
Finally, the "launch" command has a somewhat funny sequencing now.
Simply sending the command and waiting for a response yielded strange
results if the inferior did not stop -- in this case, the repsonse was
never sent. So now, the command is split into two parts, with some
setup being done synchronously (for better error propagation) and the
actual "run" being done async.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32090
Reviewed-by: Kévin Le Gouguec <legouguec@adacore.com>
82 lines
2.8 KiB
Plaintext
82 lines
2.8 KiB
Plaintext
# Copyright 2023-2024 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test DAP 'bt' through a function without debuginfo.
|
|
|
|
require allow_dap_tests
|
|
|
|
load_lib dap-support.exp
|
|
|
|
standard_testfile bt-main.c bt-inner.c
|
|
|
|
if {[build_executable_from_specs $testfile.exp $testfile {} \
|
|
$srcfile debug \
|
|
$srcfile2 {}] == -1} {
|
|
return
|
|
}
|
|
|
|
if {[dap_initialize] == ""} {
|
|
return
|
|
}
|
|
|
|
set launch_id [dap_launch $testfile]
|
|
|
|
set obj [dap_check_request_and_response "set breakpoint on inner" \
|
|
setFunctionBreakpoints \
|
|
{o breakpoints [a [o name [s function_breakpoint_here]]]}]
|
|
set fn_bpno [dap_get_breakpoint_number $obj]
|
|
|
|
dap_check_request_and_response "configurationDone" configurationDone
|
|
|
|
dap_check_response "launch response" launch $launch_id
|
|
|
|
dap_wait_for_event_and_check "inferior started" thread "body reason" started
|
|
|
|
lassign [dap_wait_for_event_and_check "stopped at function breakpoint" stopped \
|
|
"body reason" breakpoint \
|
|
"body hitBreakpointIds" $fn_bpno] unused objs
|
|
|
|
# The bug was that this request would fail.
|
|
set obj [dap_check_request_and_response "backtrace" \
|
|
stackTrace {o threadId [i 1]}]
|
|
set frames [dict get [lindex $obj 0] body stackFrames]
|
|
|
|
gdb_assert {[llength $frames] == 3} "three frames"
|
|
|
|
gdb_assert {[dict get [lindex $frames 1] name] == "no_debug_info"} \
|
|
"name of no-debug frame"
|
|
|
|
# Breakpoint can be set without source file information
|
|
set obj [dap_check_request_and_response "set breakpoint on no_debug_info" \
|
|
setFunctionBreakpoints \
|
|
{o breakpoints [a [o name [s no_debug_info]]]}]
|
|
set breakpoints [dict get [lindex $obj 0] body breakpoints]
|
|
gdb_assert {[dict exists [lindex $breakpoints 0] instructionReference]} \
|
|
"breakpoint has instructionReference"
|
|
|
|
# instructionReference is specified as a string, but it's form is not
|
|
# otherwise given in the spec. gdb always emits it as hex. A bug
|
|
# slipped in that caused this to be incorrect, so we test both parts
|
|
# here; to test whether a string was given, we have to reach into the
|
|
# TON form.
|
|
set list_form [namespace eval ton::2list $last_ton]
|
|
set ref [namespace eval ton::2list {
|
|
get $list_form body breakpoints 0 instructionReference
|
|
}]
|
|
gdb_assert {[regexp "^$hex\$" $ref]} \
|
|
"instructionReference is a hex string"
|
|
|
|
dap_shutdown
|