Fix '-data-read-memory-bytes' typo/assertion

Backported to the 7.10 branch per this thread: https://www.sourceware.org/ml/gdb-patches/2016-02/msg00134.html This patch fixes a typo in target.c:read_memory_robust, where it calls read_whatever_is_readable with the function arguments in the wrong order. Depending on the address being read, it can cause an xmalloc with a huge size, resulting in an assertion failure, or just read something other than what was requested. The problem only arises when GDB is handling an MI "-data-read-memory-bytes" request and the initial target_read returns an error status. Note that read_memory_robust is only called from the MI code. gdb/ChangeLog: * gdb/target.c (read_memory_robust): Call read_whatever_is_readable with arguments in the correct order.
Automatic date update in version.in
2016-02-10 15:42:15 -08:00 · 2016-02-10 00:00:50 +00:00 · 2016-02-09 00:00:41 +00:00 · 2016-02-08 00:00:30 +00:00 · 2016-02-07 00:00:41 +00:00 · 2016-02-06 00:00:35 +00:00
4 changed files with 18 additions and 4 deletions
--- a/bfd/version.h
+++ b/bfd/version.h
@@ -1,4 +1,4 @@
-#define BFD_VERSION_DATE 20151205
+#define BFD_VERSION_DATE 20160210
 #define BFD_VERSION @bfd_version@
 #define BFD_VERSION_STRING  @bfd_version_package@ @bfd_version_string@
 #define REPORT_BUGS_TO @report_bugs_to@
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,16 @@
+2015-11-19  Don Breazeal  <donb@codesourcery.com>
+
+	* target.c (read_memory_robust): Call read_whatever_is_readable
+	with arguments in the correct order.
+
+2015-12-05  Joel Brobecker  <brobecker@adacore.com>
+
+	* version.in: Set GDB version number to 7.10.1.DATE-cvs.
+
+2015-12-05  Joel Brobecker  <brobecker@adacore.com>
+
+	GDB 7.10.1 released.
+
 2015-12-05  Joel Brobecker  <brobecker@adacore.com>

 	* version.in: Set GDB version number to 7.10.1.
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -1822,8 +1822,9 @@ read_memory_robust (struct target_ops *ops,
 	      /* Got an error reading full chunk.  See if maybe we can read
 		 some subrange.  */
 	      xfree (buffer);
-	      read_whatever_is_readable (ops, offset + xfered_total, unit_size,
-					 offset + xfered_total + to_read, &result);
+	      read_whatever_is_readable (ops, offset + xfered_total,
+					 offset + xfered_total + to_read,
+					 unit_size, &result);
 	      xfered_total += to_read;
 	    }
 	  else
--- a/gdb/version.in
+++ b/gdb/version.in
@@ -1 +1 @@
-7.10.1
+7.10.1.DATE-cvs
Author	SHA1	Message	Date
Don Breazeal	718b36fead	Fix '-data-read-memory-bytes' typo/assertion Backported to the 7.10 branch per this thread: https://www.sourceware.org/ml/gdb-patches/2016-02/msg00134.html This patch fixes a typo in target.c:read_memory_robust, where it calls read_whatever_is_readable with the function arguments in the wrong order. Depending on the address being read, it can cause an xmalloc with a huge size, resulting in an assertion failure, or just read something other than what was requested. The problem only arises when GDB is handling an MI "-data-read-memory-bytes" request and the initial target_read returns an error status. Note that read_memory_robust is only called from the MI code. gdb/ChangeLog: * gdb/target.c (read_memory_robust): Call read_whatever_is_readable with arguments in the correct order.	2016-02-10 15:42:15 -08:00
GDB Administrator	9939a5ae6e	Automatic date update in version.in	2016-02-10 00:00:50 +00:00
GDB Administrator	fd25813522	Automatic date update in version.in	2016-02-09 00:00:41 +00:00
GDB Administrator	926ad02804	Automatic date update in version.in	2016-02-08 00:00:30 +00:00
GDB Administrator	b79c959e21	Automatic date update in version.in	2016-02-07 00:00:41 +00:00
GDB Administrator	3127b41ef6	Automatic date update in version.in	2016-02-06 00:00:35 +00:00
GDB Administrator	4ae96edcb3	Automatic date update in version.in	2016-02-05 00:00:41 +00:00
GDB Administrator	ecf717914e	Automatic date update in version.in	2016-02-04 00:00:33 +00:00
GDB Administrator	3f4ee8a5af	Automatic date update in version.in	2016-02-03 00:00:42 +00:00
GDB Administrator	26a736a1bd	Automatic date update in version.in	2016-02-02 00:00:40 +00:00
GDB Administrator	e12287ec8f	Automatic date update in version.in	2016-02-01 00:00:35 +00:00
GDB Administrator	8d9612c7d2	Automatic date update in version.in	2016-01-31 00:00:29 +00:00
GDB Administrator	4aea2ee231	Automatic date update in version.in	2016-01-30 00:00:38 +00:00
GDB Administrator	c141f0a87f	Automatic date update in version.in	2016-01-29 00:00:35 +00:00
GDB Administrator	9f4cd994a1	Automatic date update in version.in	2016-01-28 00:00:40 +00:00
GDB Administrator	04c2cc8b14	Automatic date update in version.in	2016-01-27 00:00:34 +00:00
GDB Administrator	be3fdbcf93	Automatic date update in version.in	2016-01-26 00:00:43 +00:00
GDB Administrator	e8c8175f2c	Automatic date update in version.in	2016-01-25 00:00:34 +00:00
GDB Administrator	7598c6af8f	Automatic date update in version.in	2016-01-24 00:00:35 +00:00
GDB Administrator	5e4f127a3a	Automatic date update in version.in	2016-01-23 00:00:35 +00:00
GDB Administrator	cec9b48217	Automatic date update in version.in	2016-01-22 00:00:34 +00:00
GDB Administrator	ebee3c7142	Automatic date update in version.in	2016-01-21 00:00:39 +00:00
GDB Administrator	00e38d0ad9	Automatic date update in version.in	2016-01-20 00:00:38 +00:00
GDB Administrator	79ed73a4f1	Automatic date update in version.in	2016-01-19 00:00:38 +00:00
GDB Administrator	2a02aa3e7e	Automatic date update in version.in	2016-01-18 00:00:39 +00:00
GDB Administrator	4d048bf3da	Automatic date update in version.in	2016-01-17 00:00:32 +00:00
GDB Administrator	57508eebad	Automatic date update in version.in	2016-01-16 00:00:36 +00:00
GDB Administrator	42f80d0f68	Automatic date update in version.in	2016-01-15 00:00:32 +00:00
GDB Administrator	ae977c7068	Automatic date update in version.in	2016-01-14 00:00:35 +00:00
GDB Administrator	7deecb84e6	Automatic date update in version.in	2016-01-13 00:00:31 +00:00
GDB Administrator	cabf099ef0	Automatic date update in version.in	2016-01-12 00:00:38 +00:00
GDB Administrator	632f6972dc	Automatic date update in version.in	2016-01-11 00:00:33 +00:00
GDB Administrator	eb189df08f	Automatic date update in version.in	2016-01-10 00:00:43 +00:00
GDB Administrator	45cc4c5744	Automatic date update in version.in	2016-01-09 00:00:38 +00:00
GDB Administrator	6d94cce9d7	Automatic date update in version.in	2016-01-08 00:00:39 +00:00
GDB Administrator	d89f3b4b12	Automatic date update in version.in	2016-01-07 00:00:35 +00:00
GDB Administrator	17cd0e49a3	Automatic date update in version.in	2016-01-06 00:00:40 +00:00
GDB Administrator	be6c2d9649	Automatic date update in version.in	2016-01-05 00:00:32 +00:00
GDB Administrator	81df50697b	Automatic date update in version.in	2016-01-04 00:00:34 +00:00
GDB Administrator	8e53ff3a97	Automatic date update in version.in	2016-01-03 00:00:36 +00:00
GDB Administrator	6492b30f35	Automatic date update in version.in	2016-01-02 00:00:38 +00:00
GDB Administrator	73cfbe61aa	Automatic date update in version.in	2016-01-01 00:00:37 +00:00
GDB Administrator	bb043da1cc	Automatic date update in version.in	2015-12-31 00:00:36 +00:00
GDB Administrator	d8369898ba	Automatic date update in version.in	2015-12-30 00:00:31 +00:00
GDB Administrator	f6add9d488	Automatic date update in version.in	2015-12-29 00:00:35 +00:00
GDB Administrator	79ef53bca6	Automatic date update in version.in	2015-12-28 00:00:40 +00:00
GDB Administrator	e4c8050e78	Automatic date update in version.in	2015-12-27 00:00:37 +00:00
GDB Administrator	63d364e2db	Automatic date update in version.in	2015-12-26 00:00:37 +00:00
GDB Administrator	a965854b70	Automatic date update in version.in	2015-12-25 00:00:37 +00:00
GDB Administrator	d9f1c143d1	Automatic date update in version.in	2015-12-24 00:00:32 +00:00
GDB Administrator	6174c80b48	Automatic date update in version.in	2015-12-23 00:00:38 +00:00
GDB Administrator	4fb6d3b0c9	Automatic date update in version.in	2015-12-22 00:00:36 +00:00
GDB Administrator	03c0deb558	Automatic date update in version.in	2015-12-21 00:00:33 +00:00
GDB Administrator	26463ba861	Automatic date update in version.in	2015-12-20 00:00:41 +00:00
GDB Administrator	384152a5f3	Automatic date update in version.in	2015-12-19 00:00:43 +00:00
GDB Administrator	7da8904453	Automatic date update in version.in	2015-12-18 00:00:39 +00:00
GDB Administrator	88cb7d0234	Automatic date update in version.in	2015-12-17 00:00:42 +00:00
GDB Administrator	4adca0e7be	Automatic date update in version.in	2015-12-16 00:00:40 +00:00
GDB Administrator	06fed79d51	Automatic date update in version.in	2015-12-15 00:00:44 +00:00
GDB Administrator	e566c9815c	Automatic date update in version.in	2015-12-14 00:00:42 +00:00
GDB Administrator	afd74256f0	Automatic date update in version.in	2015-12-13 00:00:33 +00:00
GDB Administrator	6e93b9b3fd	Automatic date update in version.in	2015-12-12 00:00:37 +00:00
GDB Administrator	0e585e0288	Automatic date update in version.in	2015-12-11 00:00:39 +00:00
GDB Administrator	56a0f7539e	Automatic date update in version.in	2015-12-10 00:00:31 +00:00
GDB Administrator	fa8ff6905a	Automatic date update in version.in	2015-12-09 00:00:27 +00:00
GDB Administrator	17c80a94c0	Automatic date update in version.in	2015-12-08 00:00:48 +00:00
GDB Administrator	2ed260f268	Automatic date update in version.in	2015-12-07 00:00:44 +00:00
GDB Administrator	7201fd7c2a	Automatic date update in version.in	2015-12-06 00:00:37 +00:00
Joel Brobecker	40dfe024f9	Bump GDB version number to 7.10.1.DATE-cvs. gdb/ChangeLog: * version.in: Set GDB version number to 7.10.1.DATE-cvs.	2015-12-05 16:34:00 +01:00
Joel Brobecker	bf7e6b0598	Document the GDB 7.10.1 release in gdb/ChangeLog gdb/ChangeLog: GDB 7.10.1 released.	2015-12-05 16:29:06 +01:00