Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Re: More ecoff sanity checks

Browse Source 
Another fix for fuzzed object files, exhibiting as a segfault in
nm.c filter_symbols when accessing a symbol name.

	* ecoff.c (_bfd_ecoff_slurp_symbol_table): Sanity check
	fdr_ptr->issBase, and tighten sym.iss check.
This commit is contained in:
Alan Modra
2023-06-02 08:21:36 +09:30
parent 74a965d8e0
commit e0ce6dde97
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
bfd/ecoff.c
View File

@@ -942,7 +942,9 @@ _bfd_ecoff_slurp_symbol_table (bfd *abfd)
if (fdr_ptr->isymBase < 0
|| fdr_ptr->isymBase > symhdr->isymMax
|| fdr_ptr->csym <= 0
|| fdr_ptr->csym > symhdr->isymMax - fdr_ptr->isymBase)
|| fdr_ptr->csym > symhdr->isymMax - fdr_ptr->isymBase
|| fdr_ptr->issBase < 0
|| fdr_ptr->issBase > symhdr->issMax)
continue;
lraw_src = ((char *) ecoff_data (abfd)->debug_info.external_sym
+ fdr_ptr->isymBase * external_sym_size);
@@ -955,7 +957,7 @@ _bfd_ecoff_slurp_symbol_table (bfd *abfd)
(*swap_sym_in) (abfd, (void *) lraw_src, &internal_sym);
if (internal_sym.iss >= symhdr->issMax
if (internal_sym.iss >= symhdr->issMax - fdr_ptr->issBase
|| internal_sym.iss < 0)
{
bfd_set_error (bfd_error_bad_value);