Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

2002-11-15 Andrew Cagney <ac131313@redhat.com>

Browse Source 
* complaints.h: Add comment explaining how to eliminate a
	deprecated_complain call.
This commit is contained in:
Andrew Cagney
2002-11-15 20:55:45 +00:00
parent 82d03c99f5
commit d741b867bb
2 changed files with 21 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@@ -1,3 +1,8 @@
2002-11-15 Andrew Cagney <ac131313@redhat.com>
* complaints.h: Add comment explaining how to eliminate a
deprecated_complain call.
2002-11-15 David Carlton <carlton@math.stanford.edu>
* printcmd.c: Remove #include "disasm.h".

20
gdb/complaints.h
View File

@@ -53,12 +53,24 @@ extern void clear_complaints (struct complaints **complaints,
/* Deprecated interfaces to keep the old code working (until it is all
converted to the above). Existing code such as:
struct deprecated_complaint msg = { "msg", 0, 0 };
complaint (&msg);
struct deprecated_complaint msg = { "msg 0x%08x[sic]", 0, 0 };
deprecated_complain (&msg, addr);
should be replaced by:
should be replaced by either the new call (for the singular case):
complaint (&symtab_complaints, __FILE__, __LINE__, "msg");
complaint (&symtab_complaints, "msg 0x%s", paddr (addr));
or with a wrapper function (for the many-of case):
msg_complaint (CORE_ADDR addr)
{ complaint (&symtab_complaints, "msg 0x%s", paddr (addr)); }
...
msg_complaint (addr);
Yes, the typo is intentional. The motivation behind this interface
change is to eliminate all possability of this problem re-occuring
(it has occured in the past and no one is sure that it isn't
present now).
Support for complaining about things in the symbol file that aren't
catastrophic.