Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Fix function argument and return value locations

Browse Source 
Fixes these testsuite fails on Windows:
FAIL: gdb.base/callfuncs.exp: p t_float_complex_values(fc1, fc2)
FAIL: gdb.base/callfuncs.exp: p t_float_complex_many_args(fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4)
FAIL: gdb.base/callfuncs.exp: noproto: p t_float_complex_values(fc1, fc2)
FAIL: gdb.base/callfuncs.exp: noproto: p t_float_complex_many_args(fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4, fc1, fc2, fc3, fc4)
FAIL: gdb.base/call-sc.exp: p/c fun(); call call-sc-tld
FAIL: gdb.base/call-sc.exp: advance to fun for return; return call-sc-tld
FAIL: gdb.base/call-sc.exp: zed L for return; return call-sc-tld
FAIL: gdb.base/call-sc.exp: return foo; return call-sc-tld
FAIL: gdb.base/call-sc.exp: return foo; synchronize pc to main() for 'call-sc-tld'
FAIL: gdb.base/call-sc.exp: return foo; synchronize pc to main() for 'call-sc-tld'
FAIL: gdb.base/call-sc.exp: advance to fun for finish; return call-sc-tld
FAIL: gdb.base/call-sc.exp: zed L for finish; return call-sc-tld
FAIL: gdb.base/call-sc.exp: finish foo; return call-sc-tld (the program is no longer running)
FAIL: gdb.base/call-sc.exp: value foo finished; return call-sc-tld

For function arguments (callfuncs.exp), only TYPE_CODE_COMPLEX was
missing in the types passed via integer registers.

For return values, there were a lot more issues:
- TYPE_CODE_DECFLOAT is NOT returned via XMM0.
- long double is NOT returned via XMM0.
- but __int128 IS returned via XMM0.
- the comments for TYPE_CODE_FLT state that __m128, __m128i and __m128d are
  returned by XMM0, and this is correct, but it doesn't actually check for
  them, because they are TYPE_CODE_ARRAY with TYPE_VECTOR

So I had to add TYPE_CODE_DECFLOAT to the arguments passed via XMM register,
but I had to remove it from the values returned via XMM0 register.

gdb/ChangeLog:

2020-10-05  Hannes Domani  <ssbssa@yahoo.de>

	* amd64-windows-tdep.c (amd64_windows_passed_by_integer_register):
	Add TYPE_CODE_COMPLEX.
	(amd64_windows_return_value): Fix types returned via XMM0.

gdb/testsuite/ChangeLog:

2020-10-05  Hannes Domani  <ssbssa@yahoo.de>

	* gdb.base/call-sc.c: Fix return struct on stack test case.
	* gdb.base/call-sc.exp: Likewise.
This commit is contained in:
Hannes Domani
2020-05-05 14:31:26 +02:00
parent 5b316d90e4
commit cd096ec85f
5 changed files with 46 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@@ -1,3 +1,9 @@
2020-10-05 Hannes Domani <ssbssa@yahoo.de>
* amd64-windows-tdep.c (amd64_windows_passed_by_integer_register):
Add TYPE_CODE_COMPLEX.
(amd64_windows_return_value): Fix types returned via XMM0.
2020-10-05 Alan Hayward <alan.hayward@arm.com>
* MAINTAINERS (Responsible Maintainers): Add Luis Machado to

21
gdb/amd64-windows-tdep.c
View File

@@ -125,6 +125,7 @@ amd64_windows_passed_by_integer_register (struct type *type)
case TYPE_CODE_RVALUE_REF:
case TYPE_CODE_STRUCT:
case TYPE_CODE_UNION:
case TYPE_CODE_COMPLEX:
return (TYPE_LENGTH (type) == 1
|| TYPE_LENGTH (type) == 2
|| TYPE_LENGTH (type) == 4
@@ -364,17 +365,29 @@ amd64_windows_return_value (struct gdbarch *gdbarch, struct value *function,
switch (type->code ())
{
case TYPE_CODE_FLT:
case TYPE_CODE_DECFLOAT:
/* __m128, __m128i, __m128d, floats, and doubles are returned
via XMM0. */
if (len == 4 || len == 8 || len == 16)
/* floats, and doubles are returned via XMM0. */
if (len == 4 || len == 8)
regnum = AMD64_XMM0_REGNUM;
break;
case TYPE_CODE_ARRAY:
/* __m128, __m128i and __m128d are returned via XMM0. */
if (TYPE_VECTOR (type) && len == 16)
{
enum type_code code = TYPE_TARGET_TYPE (type)->code ();
if (code == TYPE_CODE_INT || code == TYPE_CODE_FLT)
{
regnum = AMD64_XMM0_REGNUM;
break;
}
}
/* fall through */
default:
/* All other values that are 1, 2, 4 or 8 bytes long are returned
via RAX. */
if (len == 1 || len == 2 || len == 4 || len == 8)
regnum = AMD64_RAX_REGNUM;
else if (len == 16 && type->code () == TYPE_CODE_INT)
regnum = AMD64_XMM0_REGNUM;
break;
}

5
gdb/testsuite/ChangeLog
View File

@@ -1,3 +1,8 @@
2020-10-05 Hannes Domani <ssbssa@yahoo.de>
* gdb.base/call-sc.c: Fix return struct on stack test case.
* gdb.base/call-sc.exp: Likewise.
2020-10-02 Gary Benson <gbenson@redhat.com>
* README: Fix "paralell".

6
gdb/testsuite/gdb.base/call-sc.c
View File

@@ -35,6 +35,7 @@ typedef t T;
#endif
T foo = '1', L;
T init = '9';
T fun()
{
@@ -55,7 +56,10 @@ int main()
{
int i;
Fun(foo);
/* Use a different initial value then is later used in the
"value foo returned" test, so in case the struct is then returned
on the stack, it doesn't have the correct value by accident. */
Fun(init);
/* An infinite loop that first clears all the variables and then
calls the function. This "hack" is to make re-testing easier -

13
gdb/testsuite/gdb.base/call-sc.exp
View File

@@ -280,6 +280,19 @@ proc test_scalar_returns { } {
fail "${test}"
}
}
-re " = 57 .*${gdb_prompt} $" {
if $return_value_unknown {
# The struct return case.
# The return value is stored on the stack, and since GDB
# didn't override it, it still has value that was stored
# there in the earlier Foo(init) call.
pass "${test}"
} else {
# This contradicts the above claim that GDB knew
# the location of the return-value.
fail "${test}"
}
}
-re ".*${gdb_prompt} $" {
if $return_value_unimplemented {
# What a suprize. The architecture hasn't implemented