Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

[gdb/symtab] Factor out compunit_epilogue_unwind_valid

Browse Source 
Factor out compunit_epilogue_unwind_valid from both
amd64_stack_frame_destroyed_p and i386_stack_frame_destroyed_p.  No functional
changes.

Also add a comment in the new function about the assumption that in absence of
producer information, epilogue unwind info is invalid.

Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Tom de Vries
2023-02-20 12:20:14 +01:00
parent 1bcaeecb7f
commit cb911672fb
3 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/amd64-tdep.c
View File

@@ -2902,10 +2902,8 @@ static int
amd64_stack_frame_destroyed_p (struct gdbarch *gdbarch, CORE_ADDR pc)
{
gdb_byte insn;
struct compunit_symtab *cust;
cust = find_pc_compunit_symtab (pc);
if (cust != NULL && cust->epilogue_unwind_valid ())
if (compunit_epilogue_unwind_valid (find_pc_compunit_symtab (pc)))
return 0;
if (target_read_memory (pc, &insn, 1))

4
gdb/i386-tdep.c
View File

@@ -2219,10 +2219,8 @@ static int
i386_stack_frame_destroyed_p (struct gdbarch *gdbarch, CORE_ADDR pc)
{
gdb_byte insn;
struct compunit_symtab *cust;
cust = find_pc_compunit_symtab (pc);
if (cust != NULL && cust->epilogue_unwind_valid ())
if (compunit_epilogue_unwind_valid (find_pc_compunit_symtab (pc)))
return 0;
if (target_read_memory (pc, &insn, 1))

13
gdb/symtab.h
View File

@@ -1917,6 +1917,19 @@ is_main_symtab_of_compunit_symtab (struct symtab *symtab)
{
return symtab == symtab->compunit ()->primary_filetab ();
}
/* Return true if epilogue unwind info of CUST is valid. */
static inline bool
compunit_epilogue_unwind_valid (struct compunit_symtab *cust)
{
/* In absence of producer information, assume epilogue unwind info is
invalid. */
if (cust == nullptr)
return false;
return cust->epilogue_unwind_valid ();
}
/* The virtual function table is now an array of structures which have the