Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Re: More ecoff sanity checks

Browse Source 
Yet another fuzzer fix.

	* ecoff.c (ecoff_slurp_symbolic_header <FIX>): Zero counts when
	associated pointer is zero.
	(_bfd_ecoff_slurp_symbolic_info): Remove now unnecessary check.
This commit is contained in:
Alan Modra
2023-06-03 12:39:06 +09:30
parent 26cc2053e2
commit c6e6e3ab2b
1 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
bfd/ecoff.c
View File

@@ -468,6 +468,23 @@ ecoff_slurp_symbolic_header (bfd *abfd)
goto error_return;
}
#define FIX(start, count) \
if (internal_symhdr->start == 0) \
internal_symhdr->count = 0;
FIX (cbLineOffset, cbLine);
FIX (cbDnOffset, idnMax);
FIX (cbPdOffset, ipdMax);
FIX (cbSymOffset, isymMax);
FIX (cbOptOffset, ioptMax);
FIX (cbAuxOffset, iauxMax);
FIX (cbSsOffset, issMax);
FIX (cbSsExtOffset, issExtMax);
FIX (cbFdOffset, ifdMax);
FIX (cbRfdOffset, crfd);
FIX (cbExtOffset, iextMax);
#undef FIX
/* Now we can get the correct number of symbols. */
abfd->symcount = internal_symhdr->isymMax + internal_symhdr->iextMax;
@@ -580,7 +597,7 @@ _bfd_ecoff_slurp_symbolic_info (bfd *abfd,
/* Get pointers for the numeric offsets in the HDRR structure. */
#define FIX(start, count, ptr, type) \
if (internal_symhdr->start == 0 || internal_symhdr->count == 0) \
if (internal_symhdr->count == 0) \
debug->ptr = NULL; \
else \
debug->ptr = (type) ((char *) raw \