Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

ld/PE: special-case relocation types only for COFF inputs

Browse Source 
In 72cd2c7097 ("ld/PE: no base relocs for section (relative) ones") I
made a pre-existing problem quite a bit worse: When looking at a
relocation's (numerical) howto->type, that value is meaningful only if
the object was of corresponding COFF type. ELF objects in particular
have their own enumeration. As it stands, specifically the not entirely
unusual R_X86_64_32 and R_X86_64_32S did no longer have relocations
emitted for them, due to matching R_AMD64_SECTION and R_AMD64_SECREL in
value respectively.
This commit is contained in:
Jan Beulich
2025-06-11 14:32:34 +02:00
parent 0124d9f6ef
commit b09cf42d51
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ld/pe-dll.c
View File

@@ -1617,10 +1617,11 @@ generate_reloc (bfd *abfd, struct bfd_link_info *info)
printf ("rel: %s\n", sym->name);
}
if (!relocs[i]->howto->pc_relative
&& relocs[i]->howto->type != pe_details->imagebase_reloc
&& (relocs[i]->howto->type < pe_details->secrel_reloc_lo
|| relocs[i]->howto->type > pe_details->secrel_reloc_hi)
&& relocs[i]->howto->type != pe_details->section_reloc)
&& (bfd_get_flavour (b) != bfd_target_coff_flavour
|| (relocs[i]->howto->type != pe_details->imagebase_reloc
&& (relocs[i]->howto->type < pe_details->secrel_reloc_lo
|| relocs[i]->howto->type > pe_details->secrel_reloc_hi)
&& relocs[i]->howto->type != pe_details->section_reloc)))
{
struct bfd_symbol *sym = *relocs[i]->sym_ptr_ptr;
const struct bfd_link_hash_entry *blhe