Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Remove "boolean" and "var_boolean" checks from ARI

Browse Source 
The "boolean" and "var_boolean" checks from ARI seem only to generate
false reports.

Now that gdb is in C++, at least the "boolean" check seems unlikely to
ever generate a true report.

The "var_boolean" check likewise doesn't seem valuable any more --
presumably this refers to some ancient way of doing things in gdb, and
isn't likely to find a bug in the future.

Therefore, this patch removes these two checks.

gdb/ChangeLog
2019-12-13  Tom Tromey  <tromey@adacore.com>

	* contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
	checks.

Change-Id: Iaf449b51e8182ffa0b9ed25fe688e0ff64a07a67
This commit is contained in:
Tom Tromey
2019-12-05 07:53:32 -07:00
parent a5513db2f5
commit a15a95ed26
2 changed files with 5 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@@ -1,3 +1,8 @@
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
checks.
2019-12-13 Tom Tromey <tromey@adacore.com>
* gdbsupport/safe-iterator.h (class basic_safe_range) <begin,

26
gdb/contrib/ari/gdb_ari.sh
View File

@@ -1110,18 +1110,6 @@ Do not use strnicmp(), instead use strncasecmp()"
fail("strnicmp")
}
# Boolean expressions and conditionals
BEGIN { doc["boolean"] = "\
Do not use `boolean'\'', use `bool'\'' instead"
category["boolean"] = ari_regression
}
/(^|[^_[:alnum:]])boolean([^_[:alnum:]]|$)/ {
if (is_yacc_or_lex == 0) {
fail("boolean")
}
}
# Typedefs that are either redundant or can be reduced to `struct
# type *''.
# Must be placed before if assignment otherwise ARI exceptions
@@ -1143,20 +1131,6 @@ Do not use strlen dirent.d_name, instead use NAMELEN"
fail("strlen d_name")
}
BEGIN { doc["var_boolean"] = "\
Replace var_boolean with add_setshow_boolean_cmd"
category["var_boolean"] = ari_regression
fix("var_boolean", "gdb/command.h", 1)
# fix only uses the last directory level
fix("var_boolean", "cli/cli-decode.c", 2)
}
/(^|[^_[:alnum:]])var_boolean([^_[:alnum:]]|$)/ {
if (($0 !~ /(^|[^_[:alnum:]])case *var_boolean:/) \
&& ($0 !~ /(^|[^_[:alnum:]])[=!]= *var_boolean/)) {
fail("var_boolean")
}
}
BEGIN { doc["generic_use_struct_convention"] = "\
Replace generic_use_struct_convention with nothing, \
EXTRACT_STRUCT_VALUE_ADDRESS is a predicate"