Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

[gdb/testsuite] Handle missing gold linker in gdb.base/morestack.exp

Browse Source 
When running test-case gdb.base/morestack.exp without the gold linker
installed, we run into:
...
Running src/gdb/testsuite/gdb.base/morestack.exp ...
gdb compile failed, collect2: fatal error: cannot find 'ld'
compilation terminated.
FAIL: gdb.base/morestack.exp: continue

                === gdb Summary ===

nr of expected passes            1
nr of unexpected failures        1
nr of untested testcases         1
...

The test-case needs the gold linker to run correctly (as explained in commit
b8d38ee425 "testsuite: Fix false FAIL for gdb.base/morestack.exp"), but
only prefers it, and doesn't require it.

Fix this by requiring the gold linker in the test-case.  Furthermore, silence
the compilation error by introducing a caching proc have_fuse_ld_gold and
using it in this and other test-cases that use -fuse-ld=gold.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2020-07-13  Tom de Vries  <tdevries@suse.de>

	* lib/gdb.exp (have_fuse_ld_gold): New caching proc.
	* gdb.base/gcore-tls-pie.exp: Use have_fuse_ld_gold.
	* gdb.base/gold-gdb-index.exp: Same.
	* gdb.base/morestack.exp: Same.
This commit is contained in:
Tom de Vries
2020-07-13 14:14:47 +02:00
parent cf88be6855
commit 963eeee42a
5 changed files with 29 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/testsuite/ChangeLog
View File

@@ -1,3 +1,10 @@
2020-07-13 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (have_fuse_ld_gold): New caching proc.
* gdb.base/gcore-tls-pie.exp: Use have_fuse_ld_gold.
* gdb.base/gold-gdb-index.exp: Same.
* gdb.base/morestack.exp: Same.
2020-07-11 Daniel Xu <dxu@dxuuu.xyz>
PR rust/26121

4
gdb/testsuite/gdb.base/gcore-tls-pie.exp
View File

@@ -19,6 +19,10 @@
standard_testfile
if { [have_fuse_ld_gold] == 0} {
return -1
}
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug additional_flags=-fpie "ldflags=-pie -fuse-ld=gold"}]} {
return -1
}

4
gdb/testsuite/gdb.base/gold-gdb-index.exp
View File

@@ -17,6 +17,10 @@
standard_testfile .c gold-gdb-index-2.c
if { [have_fuse_ld_gold] == 0} {
return -1
}
if {[prepare_for_testing "failed to prepare" $testfile "$srcfile $srcfile2" \
{debug c++ additional_flags=-fuse-ld=gold \
additional_flags=-Wl,--gdb-index \

8
gdb/testsuite/gdb.base/morestack.exp
View File

@@ -21,13 +21,17 @@ if {$gcc_compiled == 0} {
return -1
}
if { [have_fuse_ld_gold] == 0} {
return -1
}
standard_testfile
# -fuse-ld=gold is used for calling printf code built without -fsplit-stack
# which could crash otherwise. See GCC documentation of -fsplit-stack.
set opts "additional_flags=-fsplit-stack"
if { [prepare_for_testing "failed to prepare" ${testfile} $srcfile [list $opts additional_flags=-fuse-ld=gold]] \
&& [prepare_for_testing "failed to prepare" ${testfile} $srcfile $opts] } {
if { [prepare_for_testing "failed to prepare" ${testfile} $srcfile \
[list $opts additional_flags=-fuse-ld=gold]] } {
return -1
}

8
gdb/testsuite/lib/gdb.exp
View File

@@ -7456,5 +7456,13 @@ proc gdb_note { message } {
verbose -- "NOTE: $message" 0
}
# Return 1 if compiler supports -fuse-ld=gold, otherwise return 0.
gdb_caching_proc have_fuse_ld_gold {
set me "have_fuse_ld_gold"
set flags "additional_flags=-fuse-ld=gold"
set src { int main() { return 0; } }
return [gdb_simple_compile $me $src executable $flags]
}
# Always load compatibility stuff.
load_lib future.exp