Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

gdb/linux-nat: don't memset siginfo on failure in linux_nat_get_siginfo

Browse Source 
No caller cares about the value of *SIGINFO on failure.  It's also
documented in the function doc that *SIGINFO is uninitialized (I
understand "untouched") on failure.

Change-Id: I5ef38a5f58e3635e109b919ddf6f827f38f1225a
This commit is contained in:
Simon Marchi
2022-12-02 15:09:22 -05:00
committed by Simon Marchi
parent ef632b4bf8
commit 8aa1556f2e
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/linux-nat.c
View File

@@ -4446,12 +4446,8 @@ linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo)
errno = 0;
ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo);
if (errno != 0)
{
memset (siginfo, 0, sizeof (*siginfo));
return false;
}
return true;
return errno == 0;
}
/* See nat/linux-nat.h. */