python: Add clear() to gdb.Record.

This function allows to clear the trace data from python, forcing to
re-decode the trace for successive commands.
This will be used in future ptwrite patches, to trigger re-decoding when
the ptwrite filter changes.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>
Approved-By: Markus Metzger <markus.t.metzger@intel.com>
This commit is contained in:
Felix Willgerodt
2019-02-25 15:30:29 +01:00
parent bea4f6fac4
commit 8958aefd34
6 changed files with 46 additions and 0 deletions

View File

@@ -3,6 +3,11 @@
*** Changes since GDB 15
* Python API
** Added gdb.record.clear. Clears the trace data of the current recording.
This forces re-decoding of the trace for successive commands.
* Debugger Adapter Protocol changes
** The "scopes" request will now return a scope holding global

View File

@@ -4314,6 +4314,11 @@ A @code{gdb.Record} object has the following methods:
Move the replay position to the given @var{instruction}.
@end defun
@defun Record.clear ()
Clear the trace data of the current recording. This forces re-decoding of the
trace for successive commands.
@end defun
The common @code{gdb.Instruction} class that recording method specific
instruction objects inherit from, has the following attributes:

View File

@@ -847,6 +847,19 @@ recpy_bt_goto (PyObject *self, PyObject *args)
Py_RETURN_NONE;
}
/* Implementation of BtraceRecord.clear (self) -> None. */
PyObject *
recpy_bt_clear (PyObject *self, PyObject *args)
{
const recpy_record_object * const record = (recpy_record_object *) self;
thread_info *const tinfo = record->thread;
btrace_clear (tinfo);
Py_RETURN_NONE;
}
/* BtraceList methods. */
static PyMethodDef btpy_list_methods[] =

View File

@@ -31,6 +31,9 @@ extern PyObject *recpy_bt_format (PyObject *self, void *closure);
/* Implementation of record.goto (instruction) -> None. */
extern PyObject *recpy_bt_goto (PyObject *self, PyObject *value);
/* Implementation of BtraceRecord.clear (self) -> None. */
extern PyObject *recpy_bt_clear (PyObject *self, PyObject *args);
/* Implementation of record.instruction_history [list]. */
extern PyObject *recpy_bt_instruction_history (PyObject *self, void *closure);

View File

@@ -114,6 +114,19 @@ recpy_goto (PyObject *self, PyObject *value)
return PyErr_Format (PyExc_NotImplementedError, _("Not implemented."));
}
/* Implementation of record.clear () -> None. */
static PyObject *
recpy_clear (PyObject *self, PyObject *value)
{
const recpy_record_object * const obj = (recpy_record_object *) self;
if (obj->method == RECORD_METHOD_BTRACE)
return recpy_bt_clear (self, value);
return PyErr_Format (PyExc_NotImplementedError, _("Not implemented."));
}
/* Implementation of record.replay_position [instruction] */
static PyObject *
@@ -522,6 +535,9 @@ static PyMethodDef recpy_record_methods[] = {
{ "goto", recpy_goto, METH_VARARGS,
"goto (instruction|function_call) -> None.\n\
Rewind to given location."},
{ "clear", recpy_clear, METH_VARARGS,
"clear () -> None.\n\
Clears the trace."},
{ NULL }
};

View File

@@ -144,6 +144,10 @@ with_test_prefix "instruction " {
gdb_test "python print(i.decoded)" ".*"
gdb_test "python print(i.size)" "$decimal"
gdb_test "python print(i.is_speculative)" "False"
gdb_test_no_output "python r.clear()"
gdb_test "python insn = r.instruction_history"
gdb_test_no_output "python i = insn\[0\]"
gdb_test "python print(i.size)" "$decimal" "size after clear"
}
with_test_prefix "function call" {