Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Remove ada_value_print_inner

Browse Source 
I noticed that the only caller of ada_value_print_inner is
valprint.c:do_val_print (via ada_language::value_print_inner), meaning
that the try/catch logic in this function is redundant.  This patch
removes the wrapper function.

Regression tested on x86-64 Fedora 34.
This commit is contained in:
Tom Tromey
2021-10-20 14:25:21 -06:00
parent 52429bbd71
commit 7a72f09da5
1 changed files with 5 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
gdb/ada-valprint.c
View File

@@ -978,12 +978,12 @@ ada_val_print_ref (struct type *type, const gdb_byte *valaddr,
}
/* See the comment on ada_value_print. This function differs in that
it does not catch evaluation errors (leaving that to
ada_value_print). */
it does not catch evaluation errors (leaving that to its
caller). */
static void
ada_value_print_1 (struct value *val, struct ui_file *stream, int recurse,
const struct value_print_options *options)
void
ada_value_print_inner (struct value *val, struct ui_file *stream, int recurse,
const struct value_print_options *options)
{
struct type *type = ada_check_typedef (value_type (val));
@@ -1071,25 +1071,6 @@ ada_value_print_1 (struct value *val, struct ui_file *stream, int recurse,
}
}
/* See ada-lang.h. */
void
ada_value_print_inner (struct value *val, struct ui_file *stream,
int recurse,
const struct value_print_options *options)
{
try
{
ada_value_print_1 (val, stream, recurse, options);
}
catch (const gdb_exception_error &except)
{
fprintf_styled (stream, metadata_style.style (),
_("<error reading variable: %s>"),
except.what ());
}
}
void
ada_value_print (struct value *val0, struct ui_file *stream,
const struct value_print_options *options)