Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Use enum for gdbarch's call_dummy_location

Browse Source 
This changes gdbarch to use an enum for call_dummy_location, providing
a little more type safety.
This commit is contained in:
Tom Tromey
2022-09-12 07:04:21 -06:00
parent 6c8912c64b
commit 7807dfae36
5 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/gdbarch-components.py
View File

@@ -647,7 +647,7 @@ Method(
)
Value(
type="int",
type="enum call_dummy_location_type",
name="call_dummy_location",
predefault="AT_ENTRY_POINT",
invalid=False,

4
gdb/gdbarch-gen.h
View File

@@ -331,8 +331,8 @@ typedef CORE_ADDR (gdbarch_push_dummy_call_ftype) (struct gdbarch *gdbarch, stru
extern CORE_ADDR gdbarch_push_dummy_call (struct gdbarch *gdbarch, struct value *function, struct regcache *regcache, CORE_ADDR bp_addr, int nargs, struct value **args, CORE_ADDR sp, function_call_return_method return_method, CORE_ADDR struct_addr);
extern void set_gdbarch_push_dummy_call (struct gdbarch *gdbarch, gdbarch_push_dummy_call_ftype *push_dummy_call);
extern int gdbarch_call_dummy_location (struct gdbarch *gdbarch);
extern void set_gdbarch_call_dummy_location (struct gdbarch *gdbarch, int call_dummy_location);
extern enum call_dummy_location_type gdbarch_call_dummy_location (struct gdbarch *gdbarch);
extern void set_gdbarch_call_dummy_location (struct gdbarch *gdbarch, enum call_dummy_location_type call_dummy_location);
extern bool gdbarch_push_dummy_code_p (struct gdbarch *gdbarch);

6
gdb/gdbarch.c
View File

@@ -97,7 +97,7 @@ struct gdbarch
gdbarch_dummy_id_ftype *dummy_id = default_dummy_id;
int deprecated_fp_regnum = -1;
gdbarch_push_dummy_call_ftype *push_dummy_call = nullptr;
int call_dummy_location = AT_ENTRY_POINT;
enum call_dummy_location_type call_dummy_location = AT_ENTRY_POINT;
gdbarch_push_dummy_code_ftype *push_dummy_code = nullptr;
gdbarch_code_of_frame_writable_ftype *code_of_frame_writable = default_code_of_frame_writable;
gdbarch_print_registers_info_ftype *print_registers_info = default_print_registers_info;
@@ -2229,7 +2229,7 @@ set_gdbarch_push_dummy_call (struct gdbarch *gdbarch,
gdbarch->push_dummy_call = push_dummy_call;
}
int
enum call_dummy_location_type
gdbarch_call_dummy_location (struct gdbarch *gdbarch)
{
gdb_assert (gdbarch != NULL);
@@ -2241,7 +2241,7 @@ gdbarch_call_dummy_location (struct gdbarch *gdbarch)
void
set_gdbarch_call_dummy_location (struct gdbarch *gdbarch,
int call_dummy_location)
enum call_dummy_location_type call_dummy_location)
{
gdbarch->call_dummy_location = call_dummy_location;
}

7
gdb/gdbarch.h
View File

@@ -149,6 +149,13 @@ using read_core_file_mappings_loop_ftype =
const char *filename,
const bfd_build_id *build_id)>;
/* Possible values for gdbarch_call_dummy_location. */
enum call_dummy_location_type
{
ON_STACK,
AT_ENTRY_POINT,
};
#include "gdbarch-gen.h"
/* An internal function that should _only_ be called from gdbarch_tdep.

3
gdb/inferior.h
View File

@@ -282,9 +282,6 @@ enum stop_kind
};
/* Possible values for gdbarch_call_dummy_location. */
#define ON_STACK 1
#define AT_ENTRY_POINT 4
/* Base class for target-specific inferior data. */