Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Migrate the x86 MPX handle_segmentation_fault hook to report_signal_info.

Browse Source 
gdb/ChangeLog:

	* amd64-linux-tdep.c (amd64_linux_init_abi_common): Use
	i386_linux_report_signal_info instead of
	i386_linux_handle_segmentation_fault.
	* i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Rename
	to i386_linux_report_signal_info and add siggnal argument.
	(i386_linux_init_abi): Use i386_linux_report_signal_info instead
	of i386_linux_handle_segmentation_fault.
	* i386-linux-tdep.h (i386_linux_handle_segmentation_fault): Rename
	to i386_linux_report_signal_info and add siggnal argument.
This commit is contained in:
John Baldwin
2020-07-21 17:28:16 -07:00
parent ad97bfc533
commit 77bdfeb2e6
4 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gdb/ChangeLog
View File

@@ -1,3 +1,15 @@
2020-07-21 John Baldwin <jhb@FreeBSD.org>
* amd64-linux-tdep.c (amd64_linux_init_abi_common): Use
i386_linux_report_signal_info instead of
i386_linux_handle_segmentation_fault.
* i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Rename
to i386_linux_report_signal_info and add siggnal argument.
(i386_linux_init_abi): Use i386_linux_report_signal_info instead
of i386_linux_handle_segmentation_fault.
* i386-linux-tdep.h (i386_linux_handle_segmentation_fault): Rename
to i386_linux_report_signal_info and add siggnal argument.
2020-07-21 John Baldwin <jhb@FreeBSD.org>
* corelow.c (core_target_open): Invoke gdbarch report_signal_info

3
gdb/amd64-linux-tdep.c
View File

@@ -1846,8 +1846,7 @@ amd64_linux_init_abi_common(struct gdbarch_info info, struct gdbarch *gdbarch)
set_gdbarch_process_record_signal (gdbarch, amd64_linux_record_signal);
set_gdbarch_get_siginfo_type (gdbarch, x86_linux_get_siginfo_type);
set_gdbarch_handle_segmentation_fault (gdbarch,
i386_linux_handle_segmentation_fault);
set_gdbarch_report_signal_info (gdbarch, i386_linux_report_signal_info);
}
static void

11
gdb/i386-linux-tdep.c
View File

@@ -388,19 +388,19 @@ i386_canonicalize_syscall (int syscall)
#define SIG_CODE_BONDARY_FAULT 3
/* i386 GNU/Linux implementation of the handle_segmentation_fault
/* i386 GNU/Linux implementation of the report_signal_info
gdbarch hook. Displays information related to MPX bound
violations. */
void
i386_linux_handle_segmentation_fault (struct gdbarch *gdbarch,
struct ui_out *uiout)
i386_linux_report_signal_info (struct gdbarch *gdbarch, struct ui_out *uiout,
enum gdb_signal siggnal)
{
/* -Wmaybe-uninitialized */
CORE_ADDR lower_bound = 0, upper_bound = 0, access = 0;
int is_upper;
long sig_code = 0;
if (!i386_mpx_enabled ())
if (!i386_mpx_enabled () || siggnal != GDB_SIGNAL_SEGV)
return;
try
@@ -1073,8 +1073,7 @@ i386_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
i386_linux_get_syscall_number);
set_gdbarch_get_siginfo_type (gdbarch, x86_linux_get_siginfo_type);
set_gdbarch_handle_segmentation_fault (gdbarch,
i386_linux_handle_segmentation_fault);
set_gdbarch_report_signal_info (gdbarch, i386_linux_report_signal_info);
}
void _initialize_i386_linux_tdep ();

5
gdb/i386-linux-tdep.h
View File

@@ -39,8 +39,9 @@ extern uint64_t i386_linux_core_read_xcr0 (bfd *abfd);
/* Handle and display information related to the MPX bound violation
to the user. */
extern void i386_linux_handle_segmentation_fault (struct gdbarch *gdbarch,
struct ui_out *uiout);
extern void i386_linux_report_signal_info (struct gdbarch *gdbarch,
struct ui_out *uiout,
enum gdb_signal siggnal);
/* Return the target description according to XCR0. */
extern const struct target_desc *i386_linux_read_description (uint64_t xcr0);