Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Minor fix in skip_ctf_tests

Browse Source 
I noticed an oddity in skip_ctf_tests -- for me it ends up caching the
string "!0", because it ends with 'return ![...]'.  In Tcl, this is
just string concatenation.

The result works because the users of this function have unbraced if
conditions, like:

    if [skip_ctf_tests] {

... which works because "if" re-parses the returned string as an
expression, and evaluates that.

There's only a latent bug here, but this is also un-idiomatic, so I am
checking in this patch to fix it.  This way, if someone in the future
uses a braced condition (which is what I normally recommend), it will
continue to work.

gdb/testsuite/ChangeLog
2021-02-26  Tom Tromey  <tom@tromey.com>

	* lib/gdb.exp (skip_ctf_tests): Use expr on result.
This commit is contained in:
Tom Tromey
2021-02-26 17:25:38 -07:00
parent 0cf9ea0b16
commit 573dc0cc43
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/testsuite/ChangeLog
View File

@@ -1,3 +1,7 @@
2021-02-26 Tom Tromey <tom@tromey.com>
* lib/gdb.exp (skip_ctf_tests): Use expr on result.
2021-02-26 Jan Vrany <jan.vrany@labware.com>
* gdb.trace/mi-tsv-changed.exp (test_create_delete_modify_tsv):

4
gdb/testsuite/lib/gdb.exp
View File

@@ -7433,11 +7433,13 @@ gdb_caching_proc skip_ctf_tests {
return 1
}
return ![gdb_can_simple_compile ctfdebug {
set can_ctf [gdb_can_simple_compile ctfdebug {
int main () {
return 0;
}
} executable "additional_flags=-gt"]
return [expr {!$can_ctf}]
}
# Return 1 if compiler supports -gstatement-frontiers. Otherwise,