Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Fix seg fault in linker when performing garbage collection on COFF based targets.

Browse Source 
PR ld/20401
bfd	* coffgen.c (fini_reloc_cookie_rels): Check for the extistence
	of the coff_section_data before using it.
This commit is contained in:
Nick Clifton
2016-07-27 13:18:13 +01:00
parent 7bb2fa73cb
commit 492a7a54d6
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
bfd/ChangeLog
View File

@@ -1,3 +1,13 @@
2016-07-27 Nick Clifton <nickc@redhat.com>
* Import this patch from the mainline:
2016-07-27 Ozkan Sezer <sezeroz@gmail.com>
Nick Clifton <nickc@redhat.com>
PR ld/20401
* coffgen.c (fini_reloc_cookie_rels): Check for the extistence
of the coff_section_data before using it.
2016-07-01 Tristan Gingold <gingold@adacore.com>
* version.m4: Bump version to 2.26.90

8
bfd/coffgen.c
View File

@@ -2691,7 +2691,13 @@ static void
fini_reloc_cookie_rels (struct coff_reloc_cookie *cookie,
asection *sec)
{
if (cookie->rels && coff_section_data (NULL, sec)->relocs != cookie->rels)
if (cookie->rels
/* PR 20401. The relocs may not have been cached, so check first.
If the relocs were loaded by init_reloc_cookie_rels() then this
will be the case. FIXME: Would performance be improved if the
relocs *were* cached ? */
&& coff_section_data (NULL, sec)
&& coff_section_data (NULL, sec)->relocs != cookie->rels)
free (cookie->rels);
}