Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Don't call gdbarch_pseudo_register_read_value in jit.c

Browse Source 
gdbarch_pseudo_register_read_value is not implemented in every gdbarch, so
the predicate gdbarch_pseudo_register_read_value_p is needed before
calling it.  However, there is no such guard in jit_frame_prev_register, I
am wondering how does jit work on the arch without having gdbarch method
pseudo_register_read_value.

The proper way to get register value is to call cooked_read, and then
create the value object from the buffer.

gdb:

2018-01-22  Yao Qi  <yao.qi@linaro.org>

	* jit.c (jit_frame_prev_register): Call regcache::cooked_read
	instead of gdbarch_pseudo_register_read_value.
This commit is contained in:
Yao Qi
2018-01-22 11:02:48 +00:00
parent de4cb04a20
commit 3f5a868b22
2 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@@ -1,3 +1,8 @@
2018-01-22 Yao Qi <yao.qi@linaro.org>
* jit.c (jit_frame_prev_register): Call regcache::cooked_read
instead of gdbarch_pseudo_register_read_value.
2018-01-22 Joel Brobecker <brobecker@adacore.com>
* dwarf2read.c (need_gnat_info): Return nonzero if the cu's

16
gdb/jit.c
View File

@@ -1271,19 +1271,13 @@ jit_frame_prev_register (struct frame_info *this_frame, void **cache, int reg)
return frame_unwind_got_optimized (this_frame, reg);
gdbarch = priv->regcache->arch ();
if (reg < gdbarch_num_regs (gdbarch))
{
gdb_byte *buf = (gdb_byte *) alloca (register_size (gdbarch, reg));
enum register_status status;
gdb_byte *buf = (gdb_byte *) alloca (register_size (gdbarch, reg));
enum register_status status = priv->regcache->cooked_read (reg, buf);
status = regcache_raw_read (priv->regcache, reg, buf);
if (status == REG_VALID)
return frame_unwind_got_bytes (this_frame, reg, buf);
else
return frame_unwind_got_optimized (this_frame, reg);
}
if (status == REG_VALID)
return frame_unwind_got_bytes (this_frame, reg, buf);
else
return gdbarch_pseudo_register_read_value (gdbarch, priv->regcache, reg);
return frame_unwind_got_optimized (this_frame, reg);
}
/* Relay everything back to the unwinder registered by the JIT debug