Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Style the "XXX" text in ptype/o

Browse Source 
This patch changes gdb to use the 'highlight' style on the "XXX" text
in the output of ptype/o.
This commit is contained in:
Tom Tromey
2021-05-15 08:31:42 -06:00
parent ae9150ce9e
commit 334381ea46
3 changed files with 35 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/testsuite/gdb.base/style.c
View File

@@ -34,6 +34,13 @@ struct some_struct
struct some_struct struct_value = { 23, "skidoo", VALUE_TWO };
struct just_bitfield
{
unsigned int field : 3;
};
struct just_bitfield just_bitfield_value = { 4 };
int some_called_function (void)
{
return 0;

18
gdb/testsuite/gdb.base/style.exp
View File

@@ -197,6 +197,24 @@ proc run_style_tests { } {
gdb_test "print struct_value" \
"\{$ifield = 23,.*$sfield = .*,.*$efield = $evalue.*"
set ffield [limited_style field variable]
set cstart [string_to_regexp "/* XXX "]
set cend [string_to_regexp " */"]
set p1field [limited_style "$cstart.*$decimal.*-bit.*padding.*$cend" \
highlight]
set p2field [limited_style "$cstart.*$decimal.*-byte.*padding.*$cend" \
highlight]
gdb_test "ptype/o just_bitfield_value" \
[multi_line \
".* type = struct just_bitfield {" \
".* unsigned int $ffield : 3;" \
"$p1field" \
"$p2field" \
"" \
".* total size.*: *$decimal *$cend" \
" *}.*"]
set address_style_expr [limited_style ".*\".*address.*\".*style.*" address]
set color "blue"
if { $currently_disabled_style == "address" } {

14
gdb/typeprint.c
View File

@@ -104,12 +104,18 @@ print_offset_data::maybe_print_hole (struct ui_file *stream,
unsigned int hole_bit = hole % TARGET_CHAR_BIT;
if (hole_bit > 0)
fprintf_filtered (stream, "/* XXX %2u-bit %-7s */\n", hole_bit,
for_what);
{
fprintf_styled (stream, highlight_style.style (),
"/* XXX %2u-bit %-7s */", hole_bit, for_what);
fputs_filtered ("\n", stream);
}
if (hole_byte > 0)
fprintf_filtered (stream, "/* XXX %2u-byte %-7s */\n", hole_byte,
for_what);
{
fprintf_styled (stream, highlight_style.style (),
"/* XXX %2u-byte %-7s */", hole_byte, for_what);
fputs_filtered ("\n", stream);
}
}
}