Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

timeout in mmo_get_symbols

Browse Source 
Fix mmo_get_byte to return a fail-safe value, not just on the first
call with a read error but on subsequent calls too.

	* mmo.c (mmo_get_byte): Return the fail-safe value on every
	call after a read error.
This commit is contained in:
Alan Modra
2022-08-17 16:12:26 +09:30
parent 7a1bc25b9d
commit 31e43bfffb
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
bfd/mmo.c
View File

@@ -1180,15 +1180,14 @@ mmo_get_byte (bfd *abfd)
if (abfd->tdata.mmo_data->byte_no == 0)
{
if (! abfd->tdata.mmo_data->have_error
if (!abfd->tdata.mmo_data->have_error
&& bfd_bread (abfd->tdata.mmo_data->buf, 4, abfd) != 4)
{
abfd->tdata.mmo_data->have_error = true;
abfd->tdata.mmo_data->have_error = true;
/* A value somewhat safe against tripping on some inconsistency
when mopping up after this error. */
return 128;
}
/* A value somewhat safe against tripping on some inconsistency
when mopping up after this error. */
if (abfd->tdata.mmo_data->have_error)
return 128;
}
retval = abfd->tdata.mmo_data->buf[abfd->tdata.mmo_data->byte_no];