Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

gdb: restore nullptr check in compunit_symtab::find_call_site

Browse Source 
Commit de2b4ab50d ("Convert dwarf2_cu::call_site_htab to new hash
table") removed this nullptr check for no good reason.  This causes a
crash if `m_call_site_htab` is not set, as shown in PR 32410.  My guess
is that when doing this change, I tried to make `m_call_site_htab` not a
pointer, removed this check, then realized it wasn't so obvious, and
forgot to re-add the check.

Change-Id: I455e00cdc0519dfb412dc7826d17a839b77aae69
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32410
Approved-By: Tom Tromey <tom@tromey.com>
Approved-By: Tom de Vries <tdevries@suse.de>
This commit is contained in:
Simon Marchi
2024-12-03 10:52:18 -05:00
committed by Simon Marchi
parent c3b15d468c
commit 22a7a2d12a
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gdb/symtab.c
View File

@@ -396,6 +396,9 @@ linetable_entry::pc (const struct objfile *objfile) const
call_site *
compunit_symtab::find_call_site (CORE_ADDR pc) const
{
if (m_call_site_htab == nullptr)
return nullptr;
CORE_ADDR delta = this->objfile ()->text_section_offset ();
if (auto it = m_call_site_htab->find (static_cast<unrelocated_addr> (pc - delta));