Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

elf32_arm_get_synthetic_symtab memory leak

Browse Source 
ARM get_synthetic_symtab reads .plt and caches that data.  Caching the
data doesn't make a lot of sense since get_synthetic_symtab is only
called once per bfd, and the memory might be put to better use.  It
also leaks on closing the bfd.

	* elf32-arm.c (elf32_arm_get_synthetic_symtab): Don't cache
	plt contents.  Free plt data before returning.
This commit is contained in:
Alan Modra
2023-06-21 14:33:59 +09:30
parent 9a925d0dad
commit 08edd97611
1 changed files with 10 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
bfd/elf32-arm.c
View File

@@ -20073,15 +20073,9 @@ elf32_arm_get_synthetic_symtab (bfd *abfd,
if (!elf32_arm_size_info.slurp_reloc_table (abfd, relplt, dynsyms, true))
return -1;
data = plt->contents;
if (data == NULL)
{
if (!bfd_get_full_section_contents (abfd, plt, &data)
|| data == NULL)
return -1;
plt->contents = data;
plt->flags |= SEC_IN_MEMORY;
}
data = NULL;
if (!bfd_get_full_section_contents (abfd, plt, &data))
return -1;
count = NUM_SHDR_ENTRIES (hdr);
size = count * sizeof (asymbol);
@@ -20093,13 +20087,13 @@ elf32_arm_get_synthetic_symtab (bfd *abfd,
size += sizeof ("+0x") - 1 + 8;
}
s = *ret = (asymbol *) bfd_malloc (size);
if (s == NULL)
return -1;
offset = elf32_arm_plt0_size (abfd, data);
if (offset == (bfd_vma) -1)
return -1;
if (offset == (bfd_vma) -1
|| (s = *ret = (asymbol *) bfd_malloc (size)) == NULL)
{
free (data);
return -1;
}
names = (char *) (s + count);
p = relplt->relocation;
@@ -20144,6 +20138,7 @@ elf32_arm_get_synthetic_symtab (bfd *abfd,
offset += plt_size;
}
free (data);
return n;
}