Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

gdb/testsuite/lib/dwarf.exp: fix addr_size parameter comments

Browse Source 
The comments modified in this patch claim that the addr_size parameters
can take the value 32 or 64 (suggesting the value is in bits).  In fact,
the expected value is in bytes, either 4 or 8.

The actual value in the DWARF info is in bytes.  And we can see that the
default values used (if addr_size == "default") are:

	if {$_cu_addr_size == "default"} {
	    if {[is_64_target]} {
		set _cu_addr_size 8
	    } else {
		set _cu_addr_size 4
	    }
	}

gdb/testsuite/ChangeLog:

	* lib/dwarf.exp (Dwarf::cu, Dwarf::tu, Dwarf::lines): Change valid
	values in documentation for addr_size to 4 and 8.

Change-Id: I4a02dca2bb7992198864e545ef099f020f54ff2f
This commit is contained in:
Simon Marchi
2020-07-14 23:18:01 -04:00
parent 360f1cd72d
commit 054a095926
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@@ -1,3 +1,8 @@
2020-07-14 Simon Marchi <simon.marchi@polymtl.ca>
* lib/dwarf.exp (Dwarf::cu, Dwarf::tu, Dwarf::lines): Change valid
values in documentation for addr_size to 4 and 8.
2020-07-14 Andrew Burgess <andrew.burgess@embecosm.com>
* gdb.arch/amd64-osabi.exp: Update.

6
gdb/testsuite/lib/dwarf.exp
View File

@@ -1026,7 +1026,7 @@ namespace eval Dwarf {
# default = 0 (32-bit)
# version n - DWARF version number to emit
# default = 4
# addr_size n - the size of addresses, 32, 64, or default
# addr_size n - the size of addresses in bytes: 4, 8, or default
# default = default
# fission 0|1 - boolean indicating if generating Fission debug info
# default = 0
@@ -1117,7 +1117,7 @@ namespace eval Dwarf {
# default = 0 (32-bit)
# version n - DWARF version number to emit
# default = 4
# addr_size n - the size of addresses, 32, 64, or default
# addr_size n - the size of addresses in bytes: 4, 8, or default
# default = default
# fission 0|1 - boolean indicating if generating Fission debug info
# default = 0
@@ -1298,7 +1298,7 @@ namespace eval Dwarf {
# default = 0 (32-bit)
# version n - DWARF version number to emit
# default = 4
# addr_size n - the size of addresses, 32, 64, or default
# addr_size n - the size of addresses in bytes: 4, 8, or default
# default = default
#
# LABEL is the label of the current unit (which is probably