Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

[gdb/testsuite] Fix gdb.tui/completion.exp for local-remote-host-notty

Browse Source 
When running test-case gdb.tui/completion.exp with host board
local-remote-host-notty and target board native-gdbserver, I get:
...
FAIL: gdb.tui/completion.exp: completion of layout names: \
  tab completion (timeout)
...

The test-case contains a few tests that do tab completion, which requires
readline, which is unavailable with host board local-remote-host-notty.

Fix this by adding the missing check for readline_is_used.

Tested on x86_64-linux.
This commit is contained in:
Tom de Vries
2023-03-13 17:20:09 +01:00
parent e1b8f529d3
commit 0020d62fb3
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
gdb/testsuite/gdb.tui/completion.exp
View File

@@ -48,12 +48,15 @@ proc test_tab_completion {input_line expected_re} {
}
}
with_test_prefix "completion of layout names" {
test_tab_completion "layout" "asm *next *prev *regs *split *src *"
}
if { [readline_is_used] } {
with_test_prefix "completion of layout names" {
test_tab_completion "layout" "asm *next *prev *regs *split *src *"
}
with_test_prefix "completion of focus command" {
test_tab_completion "focus" "cmd *next *prev *src *"
with_test_prefix "completion of focus command" {
test_tab_completion "focus" "cmd *next *prev *src *"
}
}
# Now run some completion tests when TUI mode is enabled.