Use _Thread_Dispatch_direct()

Use _Thread_Dispatch_direct() for operations that block the executing
thread.  This ensures that we get a fatal error
(INTERNAL_ERROR_BAD_THREAD_DISPATCH_DISABLE_LEVEL) if we try to block in
an invalid context, e.g. during system start or an interrupt handler.
This commit is contained in:
Sebastian Huber
2018-02-08 10:47:16 +01:00
parent a49dfb16cc
commit ed24ed4e0a
7 changed files with 9 additions and 9 deletions

View File

@@ -34,6 +34,6 @@ void pthread_exit( void *value_ptr )
_Thread_Exit( executing, THREAD_LIFE_TERMINATING, value_ptr );
_Thread_Dispatch_enable( cpu_self );
_Thread_Dispatch_direct( cpu_self );
RTEMS_UNREACHABLE();
}

View File

@@ -72,7 +72,7 @@ static int _POSIX_Threads_Join( pthread_t thread, void **value_ptr )
&queue_context.Lock_context.Lock_context
);
_Thread_State_release( the_thread, &queue_context.Lock_context.Lock_context );
_Thread_Dispatch_enable( cpu_self );
_Thread_Dispatch_direct( cpu_self );
} else {
_Thread_Join(
the_thread,

View File

@@ -96,7 +96,7 @@ rtems_status_code _Event_Seize(
_Thread_Unblock( executing );
}
_Thread_Dispatch_enable( cpu_self );
_Thread_Dispatch_direct( cpu_self );
return _Status_Get_after_wait( executing );
}

View File

@@ -85,7 +85,7 @@ static void _Rate_monotonic_Release_postponed_job(
cpu_self = _Thread_Dispatch_disable_critical( lock_context );
_Rate_monotonic_Release( the_period, lock_context );
_Thread_Priority_update( &queue_context );
_Thread_Dispatch_enable( cpu_self );
_Thread_Dispatch_direct( cpu_self );
}
static void _Rate_monotonic_Release_job(
@@ -263,7 +263,7 @@ static rtems_status_code _Rate_monotonic_Block_while_active(
_Thread_Unblock( executing );
}
_Thread_Dispatch_enable( cpu_self );
_Thread_Dispatch_direct( cpu_self );
return RTEMS_SUCCESSFUL;
}

View File

@@ -143,7 +143,7 @@ rtems_status_code rtems_task_mode(
_Thread_State_acquire( executing, &lock_context );
_Scheduler_Schedule( executing );
_Thread_State_release( executing, &lock_context );
_Thread_Dispatch_enable( cpu_self );
_Thread_Dispatch_direct( cpu_self );
}
return RTEMS_SUCCESSFUL;

View File

@@ -58,6 +58,6 @@ rtems_status_code rtems_task_wake_when(
_Thread_Timeout,
_Watchdog_Ticks_from_seconds( seconds )
);
_Thread_Dispatch_enable( cpu_self );
_Thread_Dispatch_direct( cpu_self );
return RTEMS_SUCCESSFUL;
}

View File

@@ -300,7 +300,7 @@ static Per_CPU_Control *_Thread_Wait_for_join(
) {
_Thread_Set_state_locked( executing, STATES_WAITING_FOR_JOIN_AT_EXIT );
_Thread_State_release( executing, &lock_context );
_Thread_Dispatch_enable( cpu_self );
_Thread_Dispatch_direct( cpu_self );
/* Let other threads run */
@@ -660,7 +660,7 @@ void _Thread_Restart_self(
_Thread_Wait_release_default( executing, lock_context );
_Thread_Priority_update( &queue_context );
_Thread_Dispatch_enable( cpu_self );
_Thread_Dispatch_direct( cpu_self );
RTEMS_UNREACHABLE();
}