RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

2011-03-15 Joel Sherrill <joel.sherrill@oarcorp.com>

Browse Source 
* libmisc/shell/main_setenv.c: Address Coverity issue 134 which
	recommends using strnXXX methods.
This commit is contained in:
Joel Sherrill
2011-03-15 15:02:41 +00:00
parent 4e553c6068
commit d252351c43
2 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cpukit/ChangeLog
View File

@@ -1,3 +1,8 @@
2011-03-15 Joel Sherrill <joel.sherrill@oarcorp.com>
* libmisc/shell/main_setenv.c: Address Coverity issue 134 which
recommends using strnXXX methods.
2011-03-15 Sebastian Huber <sebastian.huber@embedded-brains.de>
* libmisc/cpuuse/cpuusagereport.c: Avoid assumptions on execution

13
cpukit/libmisc/shell/main_setenv.c
View File

@@ -16,6 +16,13 @@
#include <rtems/shell.h>
#include "internal.h"
/*
* Limit examining or copying more than 256 characters at a time.
* Yes, this is very arbitrary. If there are POSIX constants, then
* they should be used.
*/
#define MAX 156
int rtems_shell_main_setenv(int argc, char *argv[])
{
char* env = NULL;
@@ -32,7 +39,7 @@ int rtems_shell_main_setenv(int argc, char *argv[])
env = argv[1];
for (arg = 2; arg < argc; arg++)
len += strlen(argv[arg]);
len += strnlen(argv[arg], MAX);
len += argc - 2 - 1;
@@ -44,8 +51,8 @@ int rtems_shell_main_setenv(int argc, char *argv[])
}
for (arg = 2, p = string; arg < argc; arg++) {
strcpy(p, argv[arg]);
p += strlen(argv[arg]);
strncpy(p, argv[arg], MAX);
p += strnlen(argv[arg], MAX);
if (arg < (argc - 1)) {
*p = ' ';
p++;