RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

ftpd: Restructure chroot() handling.

Browse Source 
Remove superfluous setting of errno = 0.

Update #3530.
This commit is contained in:
Sebastian Huber
2018-10-09 08:12:46 +02:00
parent dc32b6aa08
commit 84a5921d33
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cpukit/ftpd/ftpd.c
View File

@@ -1872,7 +1872,6 @@ session(rtems_task_argument arg)
while (1)
{
rtems_event_set set;
int rv;
rtems_event_receive(FTPD_RTEMS_EVENT, RTEMS_EVENT_ANY, RTEMS_NO_TIMEOUT,
&set);
@@ -1882,14 +1881,11 @@ session(rtems_task_argument arg)
&& chroot(ftpd_root) == 0);
/*
* The chdir() must immediatly follow the chroot(), otherwise static
* The chdir() must immediately follow the chroot(), otherwise static
* analysis tools may complain about a security issue.
*/
rv = chroot_made ? chdir("/") : -1;
*/
errno = 0;
if (rv == 0)
if (chroot_made && chdir("/") == 0)
{
send_reply(info, 220, FTPD_SERVER_MESSAGE);