RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

capture: Fix unaligned pointer value warning

Browse Source 
rtems_name is a four byte integer.
Giving an rtems_name as value instead of a pointer to ctrace_task_name_add()
fixes not only the compiler warning but it is also a bit more safe

For those who have asked for the warning:

../../../cpukit/libmisc/capture/capture_support.c:352:49: warning:
taking address of packed member of 'struct rtems_capture_task_record'
may result in an unaligned pointer value [-Waddress-of-packed-member]
  352 |         ctrace_task_name_add (rec_out->task_id, &task_rec.name);
      |                                                 ^~~~~~~~~~~~~~
This commit is contained in:
Frank Kühndel
2020-10-05 16:20:44 +02:00
committed by Sebastian Huber
parent 3bbd47638f
commit 59d0e6aed1
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cpukit/libmisc/capture/capture_support.c
View File

@@ -81,7 +81,7 @@ static ctrace_tasks tasks;
* Add a name.
*/
static void
ctrace_task_name_add (rtems_id id, const rtems_name* name)
ctrace_task_name_add (rtems_id id, const rtems_name name)
{
if (tasks.tasks == NULL)
{
@@ -97,7 +97,7 @@ ctrace_task_name_add (rtems_id id, const rtems_name* name)
{
if (tasks.tasks[t].id == id)
{
tasks.tasks[t].name = *name;
tasks.tasks[t].name = name;
break;
}
}
@@ -111,7 +111,7 @@ ctrace_task_name_add (rtems_id id, const rtems_name* name)
}
if (tasks.tasks != NULL)
{
tasks.tasks[tasks.count].name = *name;
tasks.tasks[tasks.count].name = name;
tasks.tasks[tasks.count].id = id;
++tasks.count;
}
@@ -349,7 +349,7 @@ rtems_capture_print_trace_records (int total, bool csv)
cpu->recs = rtems_capture_record_extract (cpu->recs,
&task_rec,
sizeof (task_rec));
ctrace_task_name_add (rec_out->task_id, &task_rec.name);
ctrace_task_name_add (rec_out->task_id, task_rec.name);
rtems_capture_print_record_task (cpu_out, rec_out, &task_rec);
}
else