RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

bsps/shared: Fix Coverity warning in MCP7940M

Browse Source 
Fixes the following Coverity warning:

** CID 1539495:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/bsps/shared/dev/rtc/mcp7940m.c: 317 in mcp7940m_set_time()

Basically coverity warns that (buf[...] & 0x7) can't be bigger than 7.
Just remove the unnecessary comparison.
This commit is contained in:
Christian Mauderer
2023-08-02 07:41:37 +02:00
parent 54a04cc917
commit 5115e6524f
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
bsps/shared/dev/rtc/mcp7940m.c
View File

@@ -312,9 +312,8 @@ static int mcp7940m_set_time(int minor, const rtems_time_of_day *time)
}
if (rv == 0) {
/* Make sure weekday is in range. Otherwise it's not relevant. */
if (RTCWKDAY_WKDAY_GET(buf[REG_RTCWKDAY]) < 1 ||
RTCWKDAY_WKDAY_GET(buf[REG_RTCWKDAY]) > 7) {
/* Make sure weekday is not 0 (out of range). Otherwise it's not used. */
if (RTCWKDAY_WKDAY_GET(buf[REG_RTCWKDAY]) < 1) {
buf[REG_RTCWKDAY] &= ~RTCWKDAY_WKDAY_MASK;
buf[REG_RTCWKDAY] |= RTCWKDAY_WKDAY(1);
}