RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

ppp: PR1943: Avoid NULL pointer access

Browse Source 
Waiting for mbufs at this level is a bad solution.  It would be better
to try to allocate a new mbuf chain before we hand over the current mbuf
chain to the upper layer.  In case the allocation fails we should drop
the current packet and use its mbuf chain for a new packet.
This commit is contained in:
Sebastian Huber
2014-10-08 11:43:10 +02:00
parent 22cd2821de
commit 3e1bf786bd
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cpukit/libnetworking/net/ppp_tty.c
View File

@@ -716,14 +716,8 @@ pppallocmbuf(struct ppp_softc *sc, struct mbuf **mp)
m = *mp;
if ( m == NULL ) {
/* get mbuf header */
MGETHDR(m, M_DONTWAIT, MT_DATA);
if ( m == NULL ) {
/* error - set condition to break out */
printf("pppallocmbuf: MGETHDR failed\n");
break;
}
MCLGET(m, M_DONTWAIT);
m->m_next = NULL;
MGETHDR(m, M_WAIT, MT_DATA);
MCLGET(m, M_WAIT);
*mp = m;
}