2010-08-25 Joel Sherrill <joel.sherrill@oarcorp.com>

Coverity Id 125
	Coverity Id 126
	* libi2c/libi2c.c: Use strncpy and snprintf.
This commit is contained in:
Joel Sherrill
2010-08-25 21:17:03 +00:00
parent 49460dc6d4
commit 39aa5cfae0
2 changed files with 12 additions and 4 deletions

View File

@@ -1,3 +1,9 @@
2010-08-25 Joel Sherrill <joel.sherrill@oarcorp.com>
Coverity Id 125
Coverity Id 126
* libi2c/libi2c.c: Use strncpy and snprintf.
2010-08-25 Joel Sherrill <joel.sherrill@oarcorp.com>
* score/src/coremsginsert.c: Fix typo.

View File

@@ -385,7 +385,8 @@ rtems_libi2c_register_bus (const char *name, rtems_libi2c_bus_t * bus)
{
int i;
rtems_status_code err;
char *nmcpy = malloc (name ? strlen (name) + 1 : 20);
size_t length = (name ? strlen (name) + 1 : 20);
char *nmcpy = malloc(length);
char tmp, *chpt;
struct stat sbuf;
@@ -394,7 +395,7 @@ rtems_libi2c_register_bus (const char *name, rtems_libi2c_bus_t * bus)
return -RTEMS_NO_MEMORY;
}
strcpy (nmcpy, name ? name : "/dev/i2c");
strncpy (nmcpy, name ? name : "/dev/i2c", length);
/* check */
if ('/' != *nmcpy) {
@@ -737,8 +738,9 @@ rtems_libi2c_register_drv (const char *name, rtems_libi2c_drv_t * drvtbl,
minor = ((i + 1) << 13) | RTEMS_LIBI2C_MAKE_MINOR (busno, i2caddr);
if (name) {
str = malloc (strlen (busses[busno].name) + strlen (name) + 2);
sprintf (str, "%s.%s", busses[busno].name, name);
size_t length = strlen (busses[busno].name) + strlen (name) + 2;
str = malloc (length);
snprintf (str, length, "%s.%s", busses[busno].name, name);
dev = rtems_filesystem_make_dev_t (rtems_libi2c_major, minor);