RTOS/rtems
1
0
Fork 0
forked from Imagelibrary/rtems
Code Pull Requests Activity

dd(1): Use a local swapbytes() function.

Browse Source 
swab(3) has restrict qualifiers for src and dst.
Avoid relying on undefined overlapping swab behavior.

Obtained From: OpenBSD
This commit is contained in:
eadler
2018-01-26 03:30:05 +00:00
committed by Sebastian Huber
parent 79fb53687b
commit 208ebf2099
1 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
cpukit/libmisc/shell/main_dd.c
View File

@@ -334,6 +334,21 @@ getfdtype(rtems_shell_dd_globals* globals, IO *io)
io->flags |= ISSEEK;
}
static void
swapbytes(void *v, size_t len)
{
unsigned char *p = v;
unsigned char t;
while (len > 1) {
t = p[0];
p[0] = p[1];
p[1] = t;
p += 2;
len -= 2;
}
}
static void
dd_in(rtems_shell_dd_globals* globals)
{
@@ -431,7 +446,7 @@ dd_in(rtems_shell_dd_globals* globals)
++st.swab;
--n;
}
swab(in.dbp, in.dbp, (size_t)n);
swapbytes(in.dbp, (size_t)n);
}
in.dbp += in.dbrcnt;