Imagelibrary/rtems
1
0
Fork 1
mirror of https://gitlab.rtems.org/rtems/rtos/rtems.git synced 2026-02-04 04:31:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

cpukit/.../scheduler*: Address -Wsign-compare warnings

Browse Source 
This warning occurs when comparing a signed variable to an unsigned one.
This is frequently an int or ssize_t variable compared to a uint32_t or
size_t. Sometimes the size_t is from a sizeof() use.

This addresses sign comparison warnings primarily in the CBS.
This commit is contained in:
Joel Sherrill
2026-01-28 11:01:55 -06:00
committed by Gedare Bloom
parent 54d703967f
commit 963ba98047
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpukit/rtems/src/schedulermapfromposix.c
View File

@@ -62,7 +62,7 @@ rtems_status_code rtems_scheduler_map_priority_from_posix(
return RTEMS_INVALID_PRIORITY;
}
if ( posix_priority >= scheduler->maximum_priority ) {
if ( (uint32_t) posix_priority >= scheduler->maximum_priority ) {
return RTEMS_INVALID_PRIORITY;
}

2
cpukit/score/src/schedulercbsattachthread.c
View File

@@ -62,7 +62,7 @@ int _Scheduler_CBS_Attach_thread (
return SCHEDULER_CBS_ERROR_NOSERVER;
}
if ( server->task_id != -1 ) {
if ( server->task_id != (rtems_id)-1 ) {
return SCHEDULER_CBS_ERROR_FULL;
}

4
cpukit/score/src/schedulercbscreateserver.c
View File

@@ -53,8 +53,8 @@ int _Scheduler_CBS_Create_server (
if ( params->budget <= 0 ||
params->deadline <= 0 ||
params->budget >= SCHEDULER_EDF_PRIO_MSB ||
params->deadline >= SCHEDULER_EDF_PRIO_MSB )
params->budget >= (time_t)SCHEDULER_EDF_PRIO_MSB ||
params->deadline >= (time_t)SCHEDULER_EDF_PRIO_MSB )
return SCHEDULER_CBS_ERROR_INVALID_PARAMETER;
for ( i = 0; i<_Scheduler_CBS_Maximum_servers; i++ ) {

2
cpukit/score/src/schedulercbsgetexecutiontime.c
View File

@@ -64,7 +64,7 @@ int _Scheduler_CBS_Get_execution_time (
return SCHEDULER_CBS_ERROR_NOSERVER;
}
if ( server->task_id == -1 ) {
if ( server->task_id == (rtems_id)-1 ) {
*exec_time = 0;
return SCHEDULER_CBS_OK;
}

4
cpukit/score/src/schedulercbssetparameters.c
View File

@@ -52,8 +52,8 @@ int _Scheduler_CBS_Set_parameters (
if ( params->budget <= 0 ||
params->deadline <= 0 ||
params->budget >= SCHEDULER_EDF_PRIO_MSB ||
params->deadline >= SCHEDULER_EDF_PRIO_MSB )
params->budget >= (time_t)SCHEDULER_EDF_PRIO_MSB ||
params->deadline >= (time_t)SCHEDULER_EDF_PRIO_MSB )
return SCHEDULER_CBS_ERROR_INVALID_PARAMETER;
if ( !_Scheduler_CBS_Server_list[server_id].initialized )