Imagelibrary/rtems
1
0
Fork 1
mirror of https://gitlab.rtems.org/rtems/rtos/rtems.git synced 2026-02-04 20:51:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

cpukit/dev/can/can-bus.c: Address type-limits warnings

Browse Source 
These changes were made to address GCC -Wtype-limits warnings.
In this case, the variables were unsigned and there was no need to
check them for being <= 0.

Updates #5388.
This commit is contained in:
Joel Sherrill
2025-11-25 08:43:09 -06:00
committed by Gedare Bloom
parent 1e93113205
commit 089a16b6e8
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
cpukit/dev/can/can-bus.c
View File

@@ -230,12 +230,12 @@ static int can_bus_ioctl_create_queue(
return -EINVAL;
}
/* Check whether correct dlen_max and buffer_size is to be set. */
if (
queue.dlen_max > CAN_FRAME_MAX_DLEN ||
queue.dlen_max < 0 ||
queue.buffer_size < 0
) {
/*
* Check whether correct dlen_max and buffer_size is to be set.
* Note that dlen_max and buffer_size are unsigned and do not need to
* be checked for < 0.
*/
if ( queue.dlen_max > CAN_FRAME_MAX_DLEN ) {
return -EINVAL;
}
@@ -248,8 +248,11 @@ static int can_bus_ioctl_create_queue(
queue.buffer_size = RTEMS_CAN_FIFO_SIZE;
}
/* Check whether correct queue priority is to be set. */
if ( queue.priority < 0 || queue.priority > RTEMS_CAN_QUEUE_PRIO_NR ) {
/*
* Check whether correct queue priority is to be set.
* Note that priority is unsigned and does not need to be checked for < 0.
*/
if ( queue.priority > RTEMS_CAN_QUEUE_PRIO_NR ) {
return -EINVAL;
}