mirror of
https://github.com/bminor/binutils-gdb.git
synced 2026-02-05 08:41:30 +00:00
b710ca0876
Correct the addend being ignored for orphan REL HI16 relocations. For assembly and non-ELF links `_bfd_mips_elf_hi16_reloc' is called from `bfd_install_relocation' and `bfd_perform_relocation' respectively via the respective howtos. It caches the relocation for later processing as `_bfd_mips_elf_lo16_reloc' is called via the corresponding LO16 reloc's howto, at which point both the HI16 and the LO16 parts are calculated and installed. If no matching LO16 relocation has been later encountered, then the cached entry is never processed, with the outstanding cached entries silently dropped at the conclusion of processing, resulting in zero addend being used for the field relocated. Dropping of the entries only happens in `_bfd_mips_elf_free_cached_info' at the time the BFD is being successfully closed and section contents long written to output. For non-ELF links dropping will also execute in `_bfd_elf_mips_get_relocated_section_contents' via a separate piece of code if the function has encountered an error. Address the issues first by factoring out code to process outstanding cached entries to `mips_elf_free_hi16_list' and then by making the function actually install the relocations cached as required. This has to happen before section contents have been written and therefore the success path wires the function call to `bfd_finalize_section_relocs', for assembly and `_bfd_elf_mips_get_relocated_section_contents' for non-ELF links. For housekeeping purposes the latter call will just drop cached entries as it happens now in the case of an error, and likewise the call from `_bfd_mips_elf_free_cached_info' is retained in case a fatal error in the assembler prevents `bfd_finalize_section_relocs' from being called. This also results in a warning being issued now about orphan REL HI16 relocations encountered in non-ELF links. Previously no such warning was produced since the cached entries were dropped. For assembly we expect the tool to have issued its own warning, so we process orphan relocations silently if successful, but still issue a warning if an error is returned. We are careful in `mips_elf_free_hi16_list' to retain any incoming BFD error as the function may be called under an error condition and if there's another failure in processing at this stage we don't want to clobber the original error. Test cases will be added with a separate change.
README for GNU development tools This directory contains various GNU compilers, assemblers, linkers, debuggers, etc., plus their support routines, definitions, and documentation. If you are receiving this as part of a GDB release, see the file gdb/README. If with a binutils release, see binutils/README, and so on. That'll give you info about this package -- supported targets, how to use it, how to report bugs, etc. It is now possible to automatically configure and build a variety of tools with one command. To build all of the tools contained herein, run the ``configure'' script here, e.g.: ./configure make To install them (by default in /usr/local/bin, /usr/local/lib, etc), then do: make install (If the configure script can't determine your type of computer, give it the name as an argument, for instance ``./configure sun4''. You can use the script ``config.sub'' to test whether a name is recognized; if it is, config.sub translates it to a triplet specifying CPU, vendor, and OS.) If you have more than one compiler on your system, it is often best to explicitly set CC in the environment before running configure, and to also set CC when running make. For example (assuming sh/bash/ksh): CC=gcc ./configure make A similar example using csh: setenv CC gcc ./configure make Much of the code and documentation enclosed is copyright by the Free Software Foundation, Inc. See the file COPYING or COPYING.LIB in the various directories, for a description of the GNU General Public License terms under which you can copy the files. REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info on where and how to report problems.