mirror of
https://github.com/bminor/binutils-gdb.git
synced 2026-05-15 11:15:43 +00:00
6a275e7ffe
I noticed that some places first check if a DIE has a
DW_AT_containing_type attribute, like so:
if (dwarf2_attr (type_die, DW_AT_containing_type, type_cu) == NULL)
return NULL;
and then call function die_containing_type, which does the same check,
erroring out if the attribute does not exist. The second check is
redundant in these cases. There is only one call site that does not do
a check before, for which the error might be relevant.
Remove the error call from die_containing_type, making it return nullptr
if the DIE does not have a DW_AT_containing_type attribute, and remove
the redundant checks in all but that one call site.
For that one call site, error out if the return value of
die_containing_type is nullptr. I changed the error message to be a
little more precise.
There is no expected behavior change, apart from the content of that
error message.
Change-Id: I99e89bd89d4fffef73f00e7ecc9d6ba11c0bd085
Approved-By: Tom Tromey <tom@tromey.com>
README for GNU development tools This directory contains various GNU compilers, assemblers, linkers, debuggers, etc., plus their support routines, definitions, and documentation. If you are receiving this as part of a GDB release, see the file gdb/README. If with a binutils release, see binutils/README, and so on. That'll give you info about this package -- supported targets, how to use it, how to report bugs, etc. It is now possible to automatically configure and build a variety of tools with one command. To build all of the tools contained herein, run the ``configure'' script here, e.g.: ./configure make To install them (by default in /usr/local/bin, /usr/local/lib, etc), then do: make install (If the configure script can't determine your type of computer, give it the name as an argument, for instance ``./configure sun4''. You can use the script ``config.sub'' to test whether a name is recognized; if it is, config.sub translates it to a triplet specifying CPU, vendor, and OS.) If you have more than one compiler on your system, it is often best to explicitly set CC in the environment before running configure, and to also set CC when running make. For example (assuming sh/bash/ksh): CC=gcc ./configure make A similar example using csh: setenv CC gcc ./configure make Much of the code and documentation enclosed is copyright by the Free Software Foundation, Inc. See the file COPYING or COPYING.LIB in the various directories, for a description of the GNU General Public License terms under which you can copy the files. REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info on where and how to report problems.