Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-11-16 04:24:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

gdbsupport: Use xsnprintf() instead of strcat() in print-utils

Browse Source 
Theoretically, in functions core_addr_to_string_nz() and
core_addr_to_string(), strcat() can overflow, so use a safe
approach using xsnprintf().

Change-Id: Ib9437450b3634dc35077234f462a03a8640242d4
This commit is contained in:
Aleksandar Rikalo
2025-06-20 09:08:07 +02:00
committed by Pedro Alves
parent 404285eda0
commit fcce95b68c
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdbsupport/print-utils.cc
View File

@@ -304,8 +304,7 @@ core_addr_to_string (const CORE_ADDR addr)
{
char *str = get_print_cell ();
strcpy (str, "0x");
strcat (str, phex (addr));
xsnprintf (str, PRINT_CELL_SIZE, "0x%s", phex (addr));
return str;
}
@@ -316,8 +315,7 @@ core_addr_to_string_nz (const CORE_ADDR addr)
{
char *str = get_print_cell ();
strcpy (str, "0x");
strcat (str, phex_nz (addr));
xsnprintf (str, PRINT_CELL_SIZE, "0x%s", phex_nz (addr));
return str;
}