Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-26 01:07:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

gdb: Fix "target file /proc/.../cmdline contained unexpected null characters"

Browse Source 
When using the gcore command, GDB prints the following warning:

    (gdb) gcore
    warning: target file /proc/.../cmdline contained unexpected null characters

The reason is that cmdline is read with target_fileio_read_stralloc(),
which warns on seeing null characters. However, it's perfectly valid
for cmdline to contain \0s, so switch to target_fileio_read_alloc().

Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Ilya Leoshkevich
2023-07-19 13:27:45 +02:00
parent 2ec31e54df
commit fa1c74b22a
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
gdb/linux-tdep.c
View File

@@ -1884,15 +1884,23 @@ linux_fill_prpsinfo (struct elf_internal_linux_prpsinfo *p)
pid = inferior_ptid.pid ();
xsnprintf (filename, sizeof (filename), "/proc/%d/cmdline", (int) pid);
/* The full name of the program which generated the corefile. */
gdb::unique_xmalloc_ptr<char> fname
= target_fileio_read_stralloc (NULL, filename);
gdb_byte *buf = NULL;
size_t buf_len = target_fileio_read_alloc (NULL, filename, &buf);
gdb::unique_xmalloc_ptr<char> fname ((char *)buf);
if (fname == NULL || fname.get ()[0] == '\0')
if (buf_len < 1 || fname.get ()[0] == '\0')
{
/* No program name was read, so we won't be able to retrieve more
information about the process. */
return 0;
}
if (fname.get ()[buf_len - 1] != '\0')
{
warning (_("target file %s "
"does not contain a trailing null character"),
filename);
return 0;
}
memset (p, 0, sizeof (*p));