Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-11-16 12:34:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

gdbserver: rename regcache's registers_valid to registers_fetched

Browse Source 
The registers_valid field of the regcache struct is used for tracking
whether we have attempted to fetch all the registers from the target.
Its name does not reflect this well, I think.  It falsely gives the
impression that all the registers are valid.  This may conflict an
individual register status, which could be REG_UNAVAILABLE.  To better
reflect the purpose, rename the field to "registers_fetched".

Approved-By: Simon Marchi <simon.marchi@efficios.com>
This commit is contained in:
Tankut Baris Aktemur
2024-12-17 08:48:03 +01:00
parent e352e20a3a
commit f7f94f9927
2 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gdbserver/regcache.cc
View File

@@ -46,7 +46,7 @@ get_thread_regcache (thread_info *thread, bool fetch)
thread->set_regcache (regcache);
}
if (fetch && !regcache->registers_valid)
if (fetch && !regcache->registers_fetched)
{
scoped_restore_current_thread restore_thread;
@@ -55,7 +55,7 @@ get_thread_regcache (thread_info *thread, bool fetch)
memset (regcache->register_status, REG_UNAVAILABLE,
regcache->tdesc->reg_defs.size ());
fetch_inferior_registers (regcache, -1);
regcache->registers_valid = true;
regcache->registers_fetched = true;
}
return regcache;
@@ -77,7 +77,7 @@ regcache_invalidate_thread (thread_info *thread)
if (regcache == NULL)
return;
if (regcache->registers_valid)
if (regcache->registers_fetched)
{
scoped_restore_current_thread restore_thread;
@@ -85,7 +85,7 @@ regcache_invalidate_thread (thread_info *thread)
store_inferior_registers (regcache, -1);
}
regcache->registers_valid = false;
regcache->registers_fetched = false;
}
/* See regcache.h. */
@@ -146,7 +146,7 @@ init_register_cache (struct regcache *regcache,
#endif
}
regcache->registers_valid = false;
regcache->registers_fetched = false;
return regcache;
}
@@ -190,7 +190,7 @@ regcache::copy_from (regcache *src)
memcpy (this->register_status, src->register_status,
src->tdesc->reg_defs.size ());
#endif
this->registers_valid = src->registers_valid;
this->registers_fetched = src->registers_fetched;
}
/* Return a reference to the description of register N. */

13
gdbserver/regcache.h
View File

@@ -33,12 +33,13 @@ struct regcache : public reg_buffer_common
/* The regcache's target description. */
const struct target_desc *tdesc = nullptr;
/* Whether the REGISTERS buffer's contents are valid. If false, we
haven't fetched the registers from the target yet. Not that this
register cache is _not_ pass-through, unlike GDB's. Note that
"valid" here is unrelated to whether the registers are available
in a traceframe. For that, check REGISTER_STATUS below. */
bool registers_valid = false;
/* Whether the REGISTERS buffer's contents are fetched. If false,
we haven't fetched the registers from the target yet. Note that
this register cache is _not_ pass-through, unlike GDB's. Also,
note that "fetched" here is unrelated to whether the registers
are available in a traceframe. For that, check REGISTER_STATUS
below. */
bool registers_fetched = false;
bool registers_owned = false;
unsigned char *registers = nullptr;
#ifndef IN_PROCESS_AGENT