Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-29 10:30:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use const more in c-lang.c

Browse Source 
This changes a few functions in c-lang.c to add "const" to parameters
and return types.  Tested by rebuilding.

gdb/ChangeLog
2020-11-13  Tom Tromey  <tom@tromey.com>

	* c-lang.c (convert_ucn, convert_octal, convert_hex)
	(convert_escape, parse_one_string): Constify.
This commit is contained in:
Tom Tromey
2020-11-13 19:40:29 -07:00
parent 1aa9981f1c
commit e8b2f0d952
2 changed files with 19 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@@ -1,3 +1,8 @@
2020-11-13 Tom Tromey <tom@tromey.com>
* c-lang.c (convert_ucn, convert_octal, convert_hex)
(convert_escape, parse_one_string): Constify.
2020-11-13 Keith Seitz <keiths@redhat.com>
https://bugzilla.redhat.com/show_bug.cgi?id=1553086

28
gdb/c-lang.c
View File

@@ -398,8 +398,8 @@ c_get_string (struct value *value, gdb::unique_xmalloc_ptr<gdb_byte> *buffer,
OUTPUT. LENGTH is the maximum length of the UCN, either 4 or 8.
Returns a pointer to just after the final digit of the UCN. */
static char *
convert_ucn (char *p, char *limit, const char *dest_charset,
static const char *
convert_ucn (const char *p, const char *limit, const char *dest_charset,
struct obstack *output, int length)
{
unsigned long result = 0;
@@ -440,9 +440,9 @@ emit_numeric_character (struct type *type, unsigned long value,
farther than LIMIT. The result is written to OUTPUT. Returns a
pointer to just after the final digit of the escape sequence. */
static char *
convert_octal (struct type *type, char *p,
char *limit, struct obstack *output)
static const char *
convert_octal (struct type *type, const char *p,
const char *limit, struct obstack *output)
{
int i;
unsigned long value = 0;
@@ -465,9 +465,9 @@ convert_octal (struct type *type, char *p,
than LIMIT. The result is written to OUTPUT. Returns a pointer to
just after the final digit of the escape sequence. */
static char *
convert_hex (struct type *type, char *p,
char *limit, struct obstack *output)
static const char *
convert_hex (struct type *type, const char *p,
const char *limit, struct obstack *output)
{
unsigned long value = 0;
@@ -496,9 +496,9 @@ convert_hex (struct type *type, char *p,
written to OUTPUT. Returns a pointer to just past the final
character of the escape sequence. */
static char *
static const char *
convert_escape (struct type *type, const char *dest_charset,
char *p, char *limit, struct obstack *output)
const char *p, const char *limit, struct obstack *output)
{
/* Skip the backslash. */
ADVANCE;
@@ -550,16 +550,16 @@ convert_escape (struct type *type, const char *dest_charset,
and TYPE is the type of target character to use. */
static void
parse_one_string (struct obstack *output, char *data, int len,
parse_one_string (struct obstack *output, const char *data, int len,
const char *dest_charset, struct type *type)
{
char *limit;
const char *limit;
limit = data + len;
while (data < limit)
{
char *p = data;
const char *p = data;
/* Look for next escape, or the end of the input. */
while (p < limit && *p != '\\')
@@ -567,7 +567,7 @@ parse_one_string (struct obstack *output, char *data, int len,
/* If we saw a run of characters, convert them all. */
if (p > data)
convert_between_encodings (host_charset (), dest_charset,
(gdb_byte *) data, p - data, 1,
(const gdb_byte *) data, p - data, 1,
output, translit_none);
/* If we saw an escape, convert it. */
if (p < limit)