Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-11-16 12:34:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

gdbsupport: make gdb::parallel_for_each's n parameter a template parameter

Browse Source 
This value will likely never change at runtime, so we might as well make
it a template parameter.  This has the "advantage" of being able to
remove the unnecessary param from gdb::sequential_for_each.

Change-Id: Ia172ab8e08964e30d4e3378a95ccfa782abce674
Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Simon Marchi
2025-05-05 16:15:26 -04:00
committed by Simon Marchi
parent 48b60fbfbc
commit e2f20b221a
3 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/minsyms.c
View File

@@ -1479,7 +1479,7 @@ minimal_symbol_reader::install ()
msymbols = m_objfile->per_bfd->msymbols.get ();
/* Arbitrarily require at least 10 elements in a thread. */
gdb::parallel_for_each (10, &msymbols[0], &msymbols[mcount],
gdb::parallel_for_each<10> (&msymbols[0], &msymbols[mcount],
[&] (minimal_symbol *start, minimal_symbol *end)
{
scoped_time_it time_it ("minsyms install worker");

4
gdb/unittests/parallel-for-selftests.c
View File

@@ -94,9 +94,9 @@ test_parallel_for_each ()
const std::vector<do_foreach_t> for_each_functions
{
[] (int start, int end, foreach_callback_t callback)
{ gdb::parallel_for_each (1, start, end, callback); },
{ gdb::parallel_for_each<1> (start, end, callback); },
[] (int start, int end, foreach_callback_t callback)
{ gdb::sequential_for_each (1, start, end, callback);}
{ gdb::sequential_for_each (start, end, callback);}
};
for (int n_threads : { 0, 1, 3 })

10
gdbsupport/parallel-for.h
View File

@@ -40,10 +40,9 @@ namespace gdb
at least N elements processed per thread. Setting N to 0 is not
allowed. */
template<class RandomIt, class RangeFunction>
template<std::size_t n, class RandomIt, class RangeFunction>
void
parallel_for_each (unsigned n, RandomIt first, RandomIt last,
RangeFunction callback)
parallel_for_each (RandomIt first, RandomIt last, RangeFunction callback)
{
/* If enabled, print debug info about how the work is distributed across
the threads. */
@@ -73,7 +72,7 @@ parallel_for_each (unsigned n, RandomIt first, RandomIt last,
if (parallel_for_each_debug)
{
debug_printf (_("Parallel for: n_elements: %zu\n"), n_elements);
debug_printf (_("Parallel for: minimum elements per thread: %u\n"), n);
debug_printf (_("Parallel for: minimum elements per thread: %zu\n"), n);
debug_printf (_("Parallel for: elts_per_thread: %zu\n"), elts_per_thread);
}
@@ -141,8 +140,7 @@ parallel_for_each (unsigned n, RandomIt first, RandomIt last,
template<class RandomIt, class RangeFunction>
void
sequential_for_each (unsigned n, RandomIt first, RandomIt last,
RangeFunction callback)
sequential_for_each (RandomIt first, RandomIt last, RangeFunction callback)
{
callback (first, last);
}