Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2026-02-04 13:21:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

MIPS/BFD: Initialize error_message' in _bfd_mips_elf_orphan_shr16_reloc'

Browse Source 
There is no value assigned in `_bfd_mips_elf_generic_reloc' via the
`error_message' parameter and consequently the original `error_message'
variable in `_bfd_mips_elf_orphan_shr16_reloc' remains uninitialized in
the error case, which newer versions of GCC can correctly diagnose:

In function '_bfd_mips_elf_orphan_shr16_reloc',
    inlined from 'mips_elf_free_hi16_list' at ../../binutils-gdb/bfd/elfxx-mips.c:13309:12:
../../binutils-gdb/bfd/elfxx-mips.c:13281:5: error: 'error_message' may be used uninitialized [-Werror=maybe-uninitialized]
13281 |     _bfd_link_reloc_status_error (abfd, info, hi->input_section,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
13282 |                                   &hi->rel, error_message, r);
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-gdb/bfd/elfxx-mips.c: In function 'mips_elf_free_hi16_list':
../../binutils-gdb/bfd/elfxx-mips.c:13255:9: note: 'error_message' declared here
13255 |   char *error_message;
      |         ^~~~~~~~~~~~~
cc1: all warnings being treated as errors

Fix the problem by preinitializing the variable to NULL as at other
places.
This commit is contained in:
Maciej W. Rozycki
2026-01-15 00:37:35 +00:00
parent d164340772
commit d9001d3683
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bfd/elfxx-mips.c
View File

@@ -13253,8 +13253,8 @@ _bfd_mips_elf_orphan_shr16_reloc (bfd *abfd, asection *sec,
{
asymbol *symbol = *hi->rel.sym_ptr_ptr;
const char *name = hi->rel.howto->name;
char *error_message = NULL;
bfd_reloc_status_type r;
char *error_message;
r = _bfd_mips_elf_shr16_reloc (abfd, &hi->rel, symbol, hi->data,
sec, hi->output_bfd, &error_message);