Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-11-16 12:34:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

gdb: make deprecated_show_value_hack use its ui_file parameter

Browse Source 
If a setting does not provide a "show" function, we fall back to the
deprecated_show_value_hack function to print the value in a generic
way. The current version ignores the `file` parameter specifying the
output file in favor of always using gdb_stdout.

To make things consistent with how the values are printed using a
regular show command, the proposed change makes the function use the
ui_file parameter it receives (even though do_show_command passes
gdb_stdout).

Co-Authored-By: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I54028ed654a1fa4d955e6e46f979472c8d98ace9
Approved-By: Andrew Burgess <aburgess@redhat.com>
This commit is contained in:
Sébastien Darche
2025-09-29 10:50:48 -04:00
parent 890bc1b7f5
commit b091f85b80
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gdb/cli/cli-setshow.c
View File

@@ -118,7 +118,7 @@ parse_cli_boolean_value (const char *arg)
static void
deprecated_show_value_hack (struct ui_file *ignore_file,
deprecated_show_value_hack (struct ui_file *file,
int ignore_from_tty,
struct cmd_list_element *c,
const char *value)
@@ -129,7 +129,7 @@ deprecated_show_value_hack (struct ui_file *ignore_file,
/* Print doc minus "Show " at start. Tell print_doc_line that
this is for a 'show value' prefix. */
print_doc_line (gdb_stdout, c->doc + 5, true);
print_doc_line (file, c->doc + 5, true);
gdb_assert (c->var.has_value ());
@@ -138,17 +138,17 @@ deprecated_show_value_hack (struct ui_file *ignore_file,
case var_string:
case var_string_noescape:
case var_enum:
gdb_printf ((" is \"%s\".\n"), value);
gdb_printf (file, _(" is \"%s\".\n"), value);
break;
case var_optional_filename:
case var_filename:
gdb_printf ((" is \"%ps\".\n"),
gdb_printf (file, _(" is \"%ps\".\n"),
styled_string (file_name_style.style (), value));
break;
default:
gdb_printf ((" is %s.\n"), value);
gdb_printf (file, _(" is %s.\n"), value);
break;
}
}
@@ -747,5 +747,3 @@ cmd_show_list (struct cmd_list_element *list, int from_tty)
}
}
}