Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-11-16 12:34:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

gdbserver: boolify and defaultize the 'fetch' parameter of get_thread_regcache

Browse Source 
Boolify the 'fetch' parameter of the get_thread_regcache function.

All of the current uses pass true for this parameter.  Therefore, define
its default value as true and remove the argument from the uses.

We still keep the parameter, though, to give downstream targets the
option to obtain a regcache without having to fetch the whole
contents.  Our (Intel) downstream target is an example.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
This commit is contained in:
Tankut Baris Aktemur
2024-12-17 08:48:02 +01:00
parent 2903d61808
commit a2cc13fad6
12 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gdbserver/linux-aarch32-low.cc
View File

@@ -170,7 +170,7 @@ struct regs_info regs_info_aarch32 =
int
arm_is_thumb_mode (void)
{
struct regcache *regcache = get_thread_regcache (current_thread, 1);
regcache *regcache = get_thread_regcache (current_thread);
unsigned long cpsr;
collect_register_by_name (regcache, "cpsr", &cpsr);

18
gdbserver/linux-low.cc
View File

@@ -788,7 +788,7 @@ linux_process_target::get_pc (lwp_info *lwp)
scoped_restore_current_thread restore_thread;
switch_to_thread (lwp->thread);
struct regcache *regcache = get_thread_regcache (current_thread, 1);
regcache *regcache = get_thread_regcache (current_thread);
CORE_ADDR pc = low_get_pc (regcache);
threads_debug_printf ("pc is 0x%lx", (long) pc);
@@ -804,7 +804,7 @@ linux_process_target::get_syscall_trapinfo (lwp_info *lwp, int *sysno)
scoped_restore_current_thread restore_thread;
switch_to_thread (lwp->thread);
regcache = get_thread_regcache (current_thread, 1);
regcache = get_thread_regcache (current_thread);
low_get_syscall_trapinfo (regcache, sysno);
threads_debug_printf ("get_syscall_trapinfo sysno %d", *sysno);
@@ -894,7 +894,7 @@ linux_process_target::save_stop_reason (lwp_info *lwp)
if (pc != sw_breakpoint_pc)
{
struct regcache *regcache
= get_thread_regcache (current_thread, 1);
= get_thread_regcache (current_thread);
low_set_pc (regcache, sw_breakpoint_pc);
}
@@ -2074,7 +2074,7 @@ linux_process_target::maybe_move_out_of_jump_pad (lwp_info *lwp, int *wstat)
(PTRACE_TYPE_ARG3) 0, &info);
}
regcache = get_thread_regcache (current_thread, 1);
regcache = get_thread_regcache (current_thread);
low_set_pc (regcache, status.tpoint_addr);
lwp->stop_pc = status.tpoint_addr;
@@ -3088,7 +3088,7 @@ linux_process_target::wait_1 (ptid_t ptid, target_waitstatus *ourstatus,
if (increment_pc != 0)
{
struct regcache *regcache
= get_thread_regcache (current_thread, 1);
= get_thread_regcache (current_thread);
event_child->stop_pc += increment_pc;
low_set_pc (regcache, event_child->stop_pc);
@@ -3376,7 +3376,7 @@ linux_process_target::wait_1 (ptid_t ptid, target_waitstatus *ourstatus,
if (low_supports_breakpoints ())
{
struct regcache *regcache
= get_thread_regcache (current_thread, 1);
= get_thread_regcache (current_thread);
low_set_pc (regcache, event_child->stop_pc);
}
@@ -3611,7 +3611,7 @@ linux_process_target::wait_1 (ptid_t ptid, target_waitstatus *ourstatus,
if (decr_pc != 0)
{
struct regcache *regcache
= get_thread_regcache (current_thread, 1);
= get_thread_regcache (current_thread);
low_set_pc (regcache, event_child->stop_pc + decr_pc);
}
}
@@ -3957,7 +3957,7 @@ void
linux_process_target::install_software_single_step_breakpoints (lwp_info *lwp)
{
thread_info *thread = lwp->thread;
struct regcache *regcache = get_thread_regcache (thread, 1);
regcache *regcache = get_thread_regcache (thread);
scoped_restore_current_thread restore_thread;
@@ -4131,7 +4131,7 @@ linux_process_target::resume_one_lwp_throw (lwp_info *lwp, int step,
if (thread->process ()->tdesc != nullptr && low_supports_breakpoints ())
{
struct regcache *regcache = get_thread_regcache (current_thread, 1);
regcache *regcache = get_thread_regcache (current_thread);
lwp->stop_pc = low_get_pc (regcache);

2
gdbserver/linux-ppc-low.cc
View File

@@ -1053,7 +1053,7 @@ ppc_target::low_get_thread_area (int lwpid, CORE_ADDR *addr)
{
struct lwp_info *lwp = find_lwp_pid (ptid_t (lwpid));
thread_info *thr = lwp->thread;
struct regcache *regcache = get_thread_regcache (thr, 1);
regcache *regcache = get_thread_regcache (thr);
ULONGEST tp = 0;
#ifdef __powerpc64__

2
gdbserver/linux-x86-low.cc
View File

@@ -361,7 +361,7 @@ x86_target::low_get_thread_area (int lwpid, CORE_ADDR *addr)
{
thread_info *thr = lwp->thread;
struct regcache *regcache = get_thread_regcache (thr, 1);
regcache *regcache = get_thread_regcache (thr);
unsigned int desc[4];
ULONGEST gs = 0;
const int reg_thread_area = 3; /* bits to scale down register value. */

4
gdbserver/mem-break.cc
View File

@@ -1238,7 +1238,7 @@ gdb_condition_true_at_breakpoint_z_type (char z_type, CORE_ADDR addr)
if (bp->cond_list == NULL)
return 1;
ctx.regcache = get_thread_regcache (current_thread, 1);
ctx.regcache = get_thread_regcache (current_thread);
ctx.tframe = NULL;
ctx.tpoint = NULL;
@@ -1360,7 +1360,7 @@ run_breakpoint_commands_z_type (char z_type, CORE_ADDR addr)
if (bp == NULL)
return 1;
ctx.regcache = get_thread_regcache (current_thread, 1);
ctx.regcache = get_thread_regcache (current_thread);
ctx.tframe = NULL;
ctx.tpoint = NULL;

2
gdbserver/proc-service.cc
View File

@@ -112,7 +112,7 @@ ps_lgetregs (gdb_ps_prochandle_t ph, lwpid_t lwpid, prgregset_t gregset)
scoped_restore_current_thread restore_thread;
switch_to_thread (lwp->thread);
regcache = get_thread_regcache (current_thread, 1);
regcache = get_thread_regcache (current_thread);
gregset_info ()->fill_function (regcache, gregset);
return PS_OK;

4
gdbserver/regcache.cc
View File

@@ -25,7 +25,7 @@
#ifndef IN_PROCESS_AGENT
struct regcache *
get_thread_regcache (thread_info *thread, int fetch)
get_thread_regcache (thread_info *thread, bool fetch)
{
regcache *regcache = thread->regcache ();
@@ -66,7 +66,7 @@ get_thread_regcache (thread_info *thread, int fetch)
reg_buffer_common *
get_thread_regcache_for_ptid (ptid_t ptid)
{
return get_thread_regcache (find_thread_ptid (ptid), 1);
return get_thread_regcache (find_thread_ptid (ptid));
}
void

2
gdbserver/regcache.h
View File

@@ -72,7 +72,7 @@ void regcache_cpy (struct regcache *dst, struct regcache *src);
struct regcache *new_register_cache (const struct target_desc *tdesc);
struct regcache *get_thread_regcache (thread_info *thread, int fetch);
regcache *get_thread_regcache (thread_info *thread, bool fetch = true);
/* Release all memory associated with the register cache for INFERIOR. */

2
gdbserver/remote-utils.cc
View File

@@ -1175,7 +1175,7 @@ prepare_resume_reply (char *buf, ptid_t ptid, const target_waitstatus &status)
switch_to_thread (the_target, ptid);
regcache = get_thread_regcache (current_thread, 1);
regcache = get_thread_regcache (current_thread);
if (the_target->stopped_by_watchpoint ())
{

4
gdbserver/server.cc
View File

@@ -4721,7 +4721,7 @@ process_serial_event (void)
write_enn (cs.own_buf);
else
{
regcache = get_thread_regcache (current_thread, 1);
regcache = get_thread_regcache (current_thread);
registers_to_string (regcache, cs.own_buf);
}
}
@@ -4738,7 +4738,7 @@ process_serial_event (void)
write_enn (cs.own_buf);
else
{
regcache = get_thread_regcache (current_thread, 1);
regcache = get_thread_regcache (current_thread);
registers_from_string (regcache, &cs.own_buf[1]);
write_ok (cs.own_buf);
}

4
gdbserver/tracepoint.cc
View File

@@ -4376,7 +4376,7 @@ tracepoint_finished_step (thread_info *tinfo, CORE_ADDR stop_pc)
wstep->tp_number, paddress (wstep->tp_address));
ctx.base.type = trap_tracepoint;
ctx.regcache = get_thread_regcache (tinfo, 1);
ctx.regcache = get_thread_regcache (tinfo);
while (wstep != NULL)
{
@@ -4537,7 +4537,7 @@ tracepoint_was_hit (thread_info *tinfo, CORE_ADDR stop_pc)
return 0;
ctx.base.type = trap_tracepoint;
ctx.regcache = get_thread_regcache (tinfo, 1);
ctx.regcache = get_thread_regcache (tinfo);
for (tpoint = tracepoints; tpoint; tpoint = tpoint->next)
{

2
gdbserver/win32-low.cc
View File

@@ -943,7 +943,7 @@ gdbserver_windows_process::handle_access_violation
static void
maybe_adjust_pc ()
{
struct regcache *regcache = get_thread_regcache (current_thread, 1);
regcache *regcache = get_thread_regcache (current_thread);
child_fetch_inferior_registers (regcache, -1);
windows_thread_info *th