Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-12-26 17:18:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix gdb.python/py-connection.exp with remote targets

Browse Source 
After the patch to make gdb_test's question non-optional when
specified, gdb.python/py-connection.exp started failing like so:

  $ make check TESTS="gdb.python/py-connection.exp" RUNTESTFLAGS="--target_board=native-gdbserver"
  (gdb) PASS: gdb.python/py-connection.exp: info connections while the connection is still around
  disconnect^M
  Ending remote debugging.^M
  (gdb) FAIL: gdb.python/py-connection.exp: kill the inferior

The problem is that "disconnect" when debugging with the native target
asks the user whether to kill the program, while with remote targets,
it doesn't.

Fix it by explicitly killing before disconnecting.

Tested with --target_board unix, native-gdbserver, and native-extended-gdbserver.

Change-Id: Icd85015c76deb84b71894715d43853c1087eba0b
This commit is contained in:
Pedro Alves
2022-05-17 12:53:32 +01:00
parent 49a73ab9d3
commit a1f2ddd383
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/testsuite/gdb.python/py-connection.exp
View File

@@ -55,8 +55,8 @@ gdb_test "python print('Same object: %s' % (conn is conn2))" "True"
# starts to return False.
gdb_test "info connections" "\r\n\\* 1 .*" \
"info connections while the connection is still around"
gdb_test "disconnect" "" "kill the inferior" \
"A program is being debugged already\\. Kill it\\? .*y or n. $" "y"
gdb_test "with confirm off -- kill" "" "kill inferior"
gdb_test "disconnect"
gdb_test "info connections" "No connections\\." \
"info connections now all the connections have gone"
gdb_test "python print(conn)" "<gdb.${connection_type} \\(invalid\\)>" \