Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-11-16 12:34:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reject compressed sections exceding 4 GiB on LLP64 machines

Browse Source 
According to the zlib FAQ (*1), zlib does not support compressed data
larger than 4 GiB when the compiler's long type is 32 bits. Therefore,
we need to report an error if a zlib-compressed debug section exceeds
4 GiB on LLP64 machines.

(*1) https://zlib.net/zlib_faq.html#faq32

Signed-off-by: Rui Ueyama <rui314@gmail.com>
This commit is contained in:
Rui Ueyama
2025-06-03 11:16:02 +09:00
committed by H.J. Lu
parent d984b08bb7
commit 9037efb547
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
bfd/compress.c
View File

@@ -521,10 +521,8 @@ decompress_contents (bool is_zstd, bfd_byte *compressed_buffer,
buffers concatenated together, so we uncompress in a loop. */
do
{
uLongf dst_len = (uncompressed_size > ULONG_MAX ? ULONG_MAX
: uncompressed_size);
uLong src_len = (compressed_size > ULONG_MAX ? ULONG_MAX
: compressed_size);
uLongf dst_len = uncompressed_size;
uLong src_len = compressed_size;
int rc = uncompress2 ((Bytef *) uncompressed_buffer, &dst_len,
(Bytef *) compressed_buffer, &src_len);
if (rc != Z_OK)
@@ -1009,6 +1007,16 @@ bfd_init_section_decompress_status (bfd *abfd, sec_ptr sec)
return false;
}
/* PR28530, reject sizes unsupported by decompress_contents. zlib
supports only up to 4 GiB input on machines whose long is 32 bits. */
if (ch_type == ch_compress_zlib
&& (sec->size != (uLong) sec->size
|| uncompressed_size != (uLongf) uncompressed_size))
{
bfd_set_error (bfd_error_nonrepresentable_section);
return false;
}
sec->compressed_size = sec->size;
sec->size = uncompressed_size;
bfd_set_section_alignment (sec, uncompressed_alignment_power);