Imagelibrary/binutils-gdb
1
0
Fork 1
mirror of https://github.com/bminor/binutils-gdb.git synced 2025-11-16 12:34:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[gdb/testsuite] Set TERM to dumb by default

Browse Source 
With MSYS2 and default TERM=xterm-256color (as well as with xterm and ansi), I
get:
...
builtin_spawn gdb -q ...
^[[6n(gdb) ERROR: GDB never initialized.
...

This is not specific to gdb, other tools produce the same CSI sequence, and
consequently we run into trouble in other places (like get_compiler_info).

Fix this by default-setting TERM to dumb.

We do this for all platforms, to avoid test-cases passing on one platform but
failing on another.

For test-cases that set TERM to something other than dumb, handle the CSI
sequence in default_gdb_start.

Approved-By: Tom Tromey <tom@tromey.com>

PR testsuite/33072
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33072
This commit is contained in:
Tom de Vries
2025-06-17 08:28:50 +02:00
parent 420aa63780
commit 7e1964f9c6
1 changed files with 27 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
gdb/testsuite/lib/gdb.exp
View File

@@ -2585,6 +2585,17 @@ proc default_gdb_start { } {
# Output with -q, and bracketed paste mode enabled, see above.
verbose "GDB initialized."
}
-re "^\033\\\[6n$gdb_prompt $" {
# With MSYS2 and TERM={xterm,ansi}, I get:
#
# builtin_spawn gdb -q ...
# ^[[6n(gdb)
#
# We set TERM to dumb by default to avoid this, but some
# test-cases set TERM to xterm or ansi, in which case we get this
# output.
verbose "GDB initialized."
}
-re "$gdb_prompt $" {
perror "GDB never initialized."
unset gdb_spawn_id
@@ -7531,6 +7542,22 @@ proc default_gdb_init { test_file_name } {
setenv LC_CTYPE C
setenv LANG C
# With MSYS2 and TERM={xterm,ansi}, I get:
#
# builtin_spawn gdb -q ...
# ^[[6n(gdb)
#
# While we're addressing this in default_gdb_start, this is not specific
# to gdb, other tools produce the same CSI sequence, and consequently we
# run into trouble in other places (like get_compiler_info).
#
# Set TERM to dumb to prevent the '^[[6n' from occurring.
#
# We could do this only for ishost *-*-mingw*, but that introduces
# inconsistency between platforms, with test-cases passing on one platform
# but failing on the other. So, we do this for all platforms.
setenv TERM dumb
# Don't let a .inputrc file or an existing setting of INPUTRC mess
# up the test results. Certain tests (style tests and TUI tests)
# want to set the terminal to a non-"dumb" value, and for those we